show compose box before report is ready after logout #16922

getusha · 2023-04-04T16:25:05Z

@techievivek @sobitneupane

Details

Fixed Issues

$ #16908
PROPOSAL: N/A

Tests

Logout from the app
Login with a working account
While the skeleton UI is loaded for the chat screen, verify that the compose box is present.
Ensure that you can't enter anything in the composer
Verify that the Add actions, Emoji Icon and Send icon are disabled.

Verify that no errors appear in the JS console

Offline tests

Login with a working account
Disconnect the device from internet
While the skeleton UI is loaded for the whole screen, verify that the compose box is present.
Ensure that you can't enter anything in the composer
Verify that the Add actions, Emoji Icon and Send icon are disabled.

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-04-04.at.7.01.25.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-04.at.7.03.32.AM.mov

Mobile Web - Safari

Screen.Recording.2023-04-04.at.7.08.05.AM.mov

Desktop

Screen.Recording.2023-04-04.at.8.00.19.AM.mov

iOS

Screen.Recording.2023-04-04.at.9.39.51.AM.mov

Android

Screen.Recording.2023-04-04.at.8.40.45.AM.mov

MelvinBot · 2023-04-04T16:25:13Z

@johnmlee101 @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-04-04T16:54:13Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

mananjadhav · 2023-04-04T16:54:59Z

@johnmlee101 Does this need C+ review?

johnmlee101 · 2023-04-04T17:14:05Z

Yes please!

mananjadhav · 2023-04-04T21:01:37Z

@johnmlee101 @getusha while the composer loads, I think we should also be able to type the chats right?

The compose box is accessible and a message can be typed even while the skeleton UI loads

Expected result from #14223

composer-while-chat-loads.mov

getusha · 2023-04-04T21:06:07Z

@mananjadhav I don't think it's a good idea to enable the compose box before even the chat list renders. It should be disabled since it's initially loading everything.

mananjadhav · 2023-04-04T21:14:13Z

I definitely agree it shouldn't be enabled. I am just highlighting it was the expected result in the linked issue, and we should update the tests accordingly and ensure it is not reported as a regression later.

mananjadhav · 2023-04-04T21:22:42Z

src/pages/home/ReportScreen.js

-                                <ReportActionsSkeletonView containerHeight={this.state.skeletonViewContainerHeight} />
+                                <>
+                                    <ReportActionsSkeletonView containerHeight={this.state.skeletonViewContainerHeight} />
+                                    <EmojiPicker ref={EmojiPickerAction.emojiPickerRef} />


I didn't understand why we should move this in this block? Also I see the linked issue is closed.

I was able to reproduce the issue it's hard to get it at first but got it after several attempts, this fixes that issue and also prevents having two EmojiPicker rendered inside ReportScreen. can you try reproducing?

As I mentioned in this comment, I think the right solution is not to move this inside an if block, rather remove two differences.

This still isn't convincing why it wouldn't open in offline mode. Hence, I think it is better to remove linking the issue, and if required tackle it separately if we're able to reproduce it consistently.

mananjadhav · 2023-04-04T21:30:34Z

@getusha Can you please remove #16913. The issue is closed and I can't be sure how we're solving by adding the EmojiPicker inside the !this.isReportReadyForDisplay() check.

I can understand you'd want to remove one extra instance of EmojiPicker (as it's loaded twice). For that I think we should:

Move EmojiPicker in ReportScreen outside of any if block.
Remove EmojiPicker from ReportActionsView

mananjadhav · 2023-04-04T21:40:18Z

@getusha Let's improve the content for our Tests:

Logout from the app

Login with a working account

While the skeleton UI is loaded for the chat screen, verify that the compose box is present.

Ensure that you can't enter anything in the composer

Verify that the Add actions, Emoji Icon and Send icon are disabled.

I think we should also update our Offline tests? QA could be same as Tests

getusha · 2023-04-04T21:47:24Z

@mananjadhav Do we need offline tests for this issue? if so what do you think about this

Login with a working account
Disconnect the device from internet
While the skeleton UI is loaded for the whole screen, verify that the compose box is present.
Ensure that you can't enter anything in the composer
Verify that the Add actions, Emoji Icon and Send icon are disabled.

mananjadhav · 2023-04-04T21:48:29Z

Yes I think it makes sense to add an offline test. The one you posted here looks fine

@getusha also just confirming are we not removing the two instances of EmojiPicker?

getusha · 2023-04-04T21:52:18Z

@mananjadhav I agree with your idea moving the EmojiPicker outside of the condition and removing the other one from ReportActionsView it makes sense, but should we handle that here as well?

mananjadhav · 2023-04-04T21:56:48Z

Yes thats what I feel, because we introduced the second instance of EmojiPicker, in the same PR, for which we're solving the regression.

What I meant by removing the other EmojiPicker related linked issue, is because we can't be certain this is what is causing the issue, and I think, we should look at it fresh/put it on hold, etc. rather than declaring resolved with this PR. What do you think?

getusha · 2023-04-04T22:01:59Z

and I think, we should look at it fresh/put it on hold, etc.

I agree, i also removed the issue from this PR description. the root cause might be different but it seems the EmojiPicker should be rendered before the conditions. like defined inside ReportActionsView

mananjadhav · 2023-04-04T22:05:14Z

i also removed the issue from this PR description. the root cause might be different

Thanks for that.

it seems the EmojiPicker should be rendered before the conditions. like defined inside ReportActionsView

I didn't understand this. Hence I recommended, removing it from ReportActionsView altogether, and in ReportScreen it should be outside of all the conditions may be just before the <PortalHost component.

getusha · 2023-04-04T22:07:23Z

This still isn't convincing why it wouldn't open in offline mode. Hence, I think it is better to remove linking the issue, and if required tackle it separately if we're able to reproduce it consistently.

@mananjadhav As you mentioned here, should we handle this separately or should i push the changes here?

mananjadhav · 2023-04-04T22:10:06Z

Apologies for the confusion. Let me clarify, I am requesting we fix the multiple EmojiPicker issues in the component tree in this PR because the linked PR introduced it.

Whether that solves the EmojiPicker in Offline mode is a separate issue, which can be first reproduced reliably, and/or kept on Hold (currently it is closed).

So yes we should just ensure we fix the changes introduced by the regression PR. Makes sense?

getusha · 2023-04-04T22:16:06Z

@mananjadhav thanks for clarifying that, just pushed the changes!

mananjadhav

Thanks for the changes and the patience here. Code looks good, will test now.

mananjadhav · 2023-04-04T22:53:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-composer-when-chat-loading.mov

Mobile Web - Chrome

mweb-chrome-composer-when-chat-loading.mov

Mobile Web - Safari

mweb-safari-composer-when-chat-loading.mov

Desktop

desktop-composer-when-chat-loading.mov

iOS

ios-composer-when-chat-loading.mov

Android

Uploading android-composer-when-chat-loading.mov…

@francoisl I have some issues with the iOS setup. I've completed the checklist for all items except iOS Native. Could you help here?

getusha · 2023-04-04T22:56:53Z

@mananjadhav is it failing to build for IOS? if you have xcode version 14.3 you should either downgrade to 14.2 or apply this workaround travis-mark/lrn@0158547

thienlnam

Taking over review from @johnmlee101 since he's offline right now and it's a deploy blocker

mananjadhav · 2023-04-04T23:49:22Z

@getusha Thanks for the link. It is definitely related to XCode 14.3 but the workaround didn't help. My issue was due to React-codegen dependency not compatible with 14.3. I've managed to fix it and updated the screencast.

@thienlnam All yours.

thienlnam · 2023-04-04T23:55:34Z

Oh perfect, I was working on fixing my simulator to test but this works as well!

(cherry picked from commit efe0a09)

…-16922 🍒 Cherry pick PR #16922 to staging 🍒

OSBotify · 2023-04-05T01:12:21Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

sobitneupane · 2023-04-05T02:14:57Z

Thanks @mananjadhav @getusha for handling the blocker.

OSBotify · 2023-04-05T02:28:05Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:34:01Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:51:46Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show compose box before report is ready after logout

3303b3c

getusha requested a review from a team as a code owner April 4, 2023 16:25

melvin-bot bot requested review from johnmlee101 and mananjadhav and removed request for a team April 4, 2023 16:25

getusha mentioned this pull request Apr 4, 2023

[HOLD for payment 2023-04-13] [HOLD for payment 2023-04-12] Composer hidden while showing skeleton after login #16908

Closed

6 tasks

johnmlee101 added the CP Staging label Apr 4, 2023

mananjadhav reviewed Apr 4, 2023

View reviewed changes

revert EmojiPicker to render with ReportFooter

84426be

render EmojiPicker once inside ReportScreen only

f7762c7

mananjadhav approved these changes Apr 4, 2023

View reviewed changes

thienlnam reviewed Apr 4, 2023

View reviewed changes

thienlnam approved these changes Apr 4, 2023

View reviewed changes

thienlnam merged commit efe0a09 into Expensify:main Apr 4, 2023

OSBotify mentioned this pull request Apr 5, 2023

🍒 Cherry pick PR #16922 to staging 🍒 #16948

Merged

OSBotify pushed a commit that referenced this pull request Apr 5, 2023

Merge pull request #16922 from getusha/show-compose-box-after-logout

45e2549

(cherry picked from commit efe0a09)

OSBotify added a commit that referenced this pull request Apr 5, 2023

Merge pull request #16948 from Expensify/OSBotify-cherry-pick-staging…

cbc767c

…-16922 🍒 Cherry pick PR #16922 to staging 🍒

OSBotify mentioned this pull request Apr 5, 2023

Deploy Checklist: New Expensify 2023-04-03 #16880

Closed

21 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

bernhardoj mentioned this pull request Jun 28, 2023

Fix crash when edit a message after coming back from a child report #21227

Merged

57 tasks

show compose box before report is ready after logout #16922

show compose box before report is ready after logout #16922

Uh oh!

Conversation

getusha commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 4, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

johnmlee101 commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

mananjadhav Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

getusha Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav Apr 4, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

getusha commented Apr 4, 2023

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Apr 4, 2023

Uh oh!

thienlnam commented Apr 4, 2023

Uh oh!

OSBotify commented Apr 5, 2023

Uh oh!

getusha commented Apr 4, 2023 •

edited

Loading

mananjadhav commented Apr 4, 2023 •

edited

Loading

mananjadhav commented Apr 4, 2023 •

edited

Loading

getusha commented Apr 4, 2023 •

edited

Loading