Fix the native link renderer #10503

parasharrajat · 2022-08-23T18:38:56Z

Details

During refactor, I deleted the native file and missed the part where native RN does not have href the attribute.
Reverting those files to handle native links via press handler.

Fixed Issues

$ #10431
$ #9739

Tests

Open the app.
Send a message with the following links.
Confirm that all of those show tooltips.
Check that if you are on the staging app, a URL with an address matching with staging opens internally. Old Expensify links open in a new tab but you are directly logged into the old Expensify app if the URL is valid.
Open the Storybook server.
Got Banner with Link and check that it renders both internal and public links.
There should be no tooltips for the links.

Note: Clicking on the internal links does not open them internally on storyBook. This is known and not a bug.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Open the app.
Send a message with the following links.
Send a few more valid links.

 new.expensify.com/settings/profile
 staging.new.expensify.com/settings
 https://www.expensify.com/inbox

Confirm that all of those show tooltips.
Check that if you are on the staging app, a URL with an address matching with staging opens internally. Url should be a valid app URL. For eg (/settings)
Old Expensify links open in a new tab but you are directly logged into the old Expensify app if the URL is valid.
Public links open in a new tab.
Open the Storybook server.
Go to Banner with Link and check that it renders both internal and public links.
There should be no tooltips for the links.

Note: Clicking on the internal links does not open them internally on the storyBook server. This is known and not a bug.

Verify that no errors appear in the JS console

Screenshots

Web

screen-2022-08-24_23.54.56.mp4

Mobile Web

Screenrecorder-2022-08-25-00-31-29-186.0.mp4

Desktop

iOS

screen-2022-08-24_22.42.33.mp4

Android

screen-2022-08-25_00.42.31.mp4

github-actions · 2022-08-24T15:02:59Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

parasharrajat · 2022-08-30T17:12:59Z

Awaiting review.

mananjadhav · 2022-08-30T19:36:48Z

The changes look fine, @parasharrajat did you face this problem that desktop App didn't build for you? I can see CONST.js is outdated compared to main.

RROR in ./src/CONST.js 793:26
[Main] Module parse failed: Identifier directly after number (793:26)
[Main] You may need an appropriate loader to handle this file type, currently no lo

parasharrajat · 2022-08-30T19:41:36Z

I did, I reported this issue https://expensify.slack.com/archives/C01GTK53T8Q/p1661361515615089.

mananjadhav · 2022-08-30T19:44:28Z

Are you not able to build even after taking the latest pull from main branch?

parasharrajat · 2022-08-30T19:45:11Z

Also, do I need to worry about these issues #9739 (comment)? Separate GH issues have been created for those but asking as they may be popped up after my changes.

mananjadhav · 2022-08-31T00:24:58Z

The changes look fine and tests work.

Separate GH issues have been created for those but asking as they may be popped up after my changes.

Can you clarify what you mean here? Are you saying these bugs didn't exist earlier and they do now with the last PR changes?

parasharrajat · 2022-08-31T04:41:58Z

I noticed those issues only on the previous PR so I thought to bring those up here. I will check those in the previous commits.

parasharrajat · 2022-09-01T17:49:44Z

Ok, so I tested the last commit before the first PR was merged, and I can confirm that those issues were still present. for example. new.expensify.com/index link was throwing the same error and just noticed those errors in the #9739 (comment) are taken before the PR was created.

mananjadhav · 2022-09-05T07:59:02Z

@parasharrajat Have you synced the branch with the latest main? I can test it once that is done.

…ink-native

parasharrajat · 2022-09-05T08:02:32Z

Updated.

mananjadhav · 2022-09-05T19:43:56Z

🎀 👀 🎀
C+ reviewed

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc - @marcaaron @parasharrajat

AndrewGable · 2022-09-06T12:57:54Z

@parasharrajat - Your checklist in the PR body was using an older version. Please make sure to use the one in the PR checklist and not an older version or the test will fail.

I've updated it to the one we use on main and tests are now passing.

parasharrajat · 2022-09-06T13:36:41Z

Thanks, @AndrewGable, I will keep an eye on this.

mananjadhav · 2022-09-13T06:56:38Z

@marcaaron Quick bump on this one.

melvin-bot · 2022-09-13T15:10:47Z

@marcaaron looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcaaron · 2022-09-13T15:11:29Z

Not emergency - related to checklist checker failing.

OSBotify · 2022-09-13T15:14:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

francoisl · 2022-09-14T22:28:47Z

🚀 Cherry-picked to staging by @francoisl in version: 1.2.0-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Note: we had a conflict on the staging branch which ended up needing to be manually fixed, so this PR doesn't automatically appear in the diff between production and staging - so I'm manually adding the note that it was CPed to staging here.

OSBotify · 2022-09-16T02:47:17Z

🚀 Deployed to staging by @marcaaron in version: 1.2.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

This was referenced Aug 23, 2022

[HOLD for payment 2022-09-26] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here #9739

Closed

[Bug] IOS/Android - Unable to open links via App. #10431

Closed

Fix links for Native platforms

d42b51b

parasharrajat force-pushed the fix-link-native branch from 56a78f7 to d42b51b Compare August 24, 2022 16:29

parasharrajat marked this pull request as ready for review August 24, 2022 19:10

parasharrajat requested a review from a team as a code owner August 24, 2022 19:10

melvin-bot bot requested review from mananjadhav and marcaaron and removed request for a team August 24, 2022 19:10

parasharrajat mentioned this pull request Aug 30, 2022

[$250] Cannot open WhatsApp chat URLs from NewDot #10630

Closed

Merge branch 'main' of github.com:Expensify/Expensify.cash into fix-l…

8ba409a

…ink-native

AndrewGable mentioned this pull request Sep 6, 2022

New Contributor Checklist is running on issue comments #10802

Closed

marcaaron approved these changes Sep 13, 2022

View reviewed changes

marcaaron merged commit c614dfc into Expensify:main Sep 13, 2022

melvin-bot bot added the Emergency label Sep 13, 2022

marcaaron removed the Emergency label Sep 13, 2022

parasharrajat deleted the fix-link-native branch September 13, 2022 16:20

francoisl mentioned this pull request Sep 14, 2022

Deploy Checklist: New Expensify 2022-09-13 #10958

Closed

30 tasks

OSBotify mentioned this pull request Sep 16, 2022

Deploy Checklist: New Expensify 2022-09-16 #11043

Closed

27 tasks

parasharrajat mentioned this pull request Sep 16, 2022

[No QA] Fix propType warning #11070

Merged

93 tasks

Fix the native link renderer #10503

Fix the native link renderer #10503

Uh oh!

Conversation

parasharrajat commented Aug 23, 2022 • edited by AndrewGable Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

github-actions bot commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Aug 30, 2022

Uh oh!

mananjadhav commented Aug 30, 2022

Uh oh!

parasharrajat commented Aug 30, 2022

Uh oh!

mananjadhav commented Aug 30, 2022

Uh oh!

parasharrajat commented Aug 30, 2022

Uh oh!

mananjadhav commented Aug 31, 2022

Uh oh!

parasharrajat commented Aug 31, 2022

Uh oh!

parasharrajat commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Sep 5, 2022

Uh oh!

parasharrajat commented Sep 5, 2022

Uh oh!

mananjadhav commented Sep 5, 2022

PR Reviewer Checklist

Uh oh!

AndrewGable commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Sep 6, 2022

Uh oh!

mananjadhav commented Sep 13, 2022

Uh oh!

melvin-bot bot commented Sep 13, 2022

Uh oh!

marcaaron commented Sep 13, 2022

Uh oh!

OSBotify commented Sep 13, 2022

Uh oh!

francoisl commented Sep 14, 2022

Uh oh!

OSBotify commented Sep 16, 2022

Uh oh!

Uh oh!

parasharrajat commented Aug 23, 2022 •

edited by AndrewGable

Loading

github-actions bot commented Aug 24, 2022 •

edited

Loading

parasharrajat commented Sep 1, 2022 •

edited

Loading

AndrewGable commented Sep 6, 2022 •

edited

Loading