Skip to content

New Contributor Checklist is running on issue comments #10802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndrewGable opened this issue Sep 2, 2022 · 5 comments · Fixed by #10834
Closed

New Contributor Checklist is running on issue comments #10802

AndrewGable opened this issue Sep 2, 2022 · 5 comments · Fixed by #10834
Assignees
Labels
Daily KSv2

Comments

@AndrewGable
Copy link
Contributor

Problem

The new contributor checklist should only be running on PRs, not on issues. https://github.com/Expensify/App/runs/8160318360?check_suite_focus=true

Solution

Update when the contributor checklist test is running here: https://github.com/Expensify/App/blob/main/.github/workflows/testChecklists.yml#L13

@AndrewGable AndrewGable added the Daily KSv2 label Sep 2, 2022
@AndrewGable AndrewGable self-assigned this Sep 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2022
@AndrewGable
Copy link
Contributor Author

Been testing solutions, I can confirm the logic here is not working.

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2022
@AndrewGable
Copy link
Contributor Author

@roryabraham failing here: #7846

@mananjadhav https://expensify.slack.com/archives/C02NK2DQWUX/p1662453718378199?thread_ts=1662366794.882629&cid=C02NK2DQWUX

@AndrewGable
Copy link
Contributor Author

For @mananjadhav - It seems like issue_comment is not running.

@AndrewGable
Copy link
Contributor Author

Never mind- Looks like actually everything is working from what I can see.

@mananjadhav for your issues:

  1. 10535: set the outline style based on outline width #10769 (review) is passing ✅
  2. added onLayout to textinput perent component & used dynamic height in… #10455 (comment) is passing ✅
  3. Fix the native link renderer #10503 (comment) was using an outdated checklist. Updated it to the recent one and now it works. ✅

I would say, give the checks a ~minute to start running. Sometimes I think they aren't running, but they actually just took a minute to start up.

@mananjadhav
Copy link
Collaborator

Ohh thanks for checking this out @AndrewGable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants