Skip to content

OpenReport API returns empty lastActorAccountID when the last reportAction is ACTIONABLEJOINREQUEST type #60154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoangzinh opened this issue Apr 12, 2025 · 18 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@hoangzinh
Copy link
Contributor

Original GH:
#51069

Action Performed:

  1. Log in as user A
  2. Go to workspace settings
  3. Click "share" and copy the URL
  4. Open the URL and login with different account user B
  5. Log-in back to user A and go to #admin room of the workspace
  6. Reload the report screen

Expected Result:

In LHN, it should show "Expensify: {userB email} requested to join the workspace"

Actual Result:

In LHN, it's showing "You: {userB email} requested to join the workspace"

Screenshots/Videos

Add any screenshot/video evidence

Please checkout #58897 (comment)

@hoangzinh hoangzinh added AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Apr 12, 2025
Copy link

melvin-bot bot commented Apr 12, 2025

Triggered auto assignment to @yuwenmemon (AutoAssignerNewDotQuality)

@hoangzinh
Copy link
Contributor Author

cc @AndrewGable ^

@melvin-bot melvin-bot bot added the Overdue label Apr 14, 2025
@yuwenmemon
Copy link
Contributor

I can look into this

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 16, 2025
Copy link

melvin-bot bot commented Apr 21, 2025

@yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

@hoangzinh
Copy link
Contributor Author

How is this issue going? @yuwenmemon @AndrewGable

@yuwenmemon
Copy link
Contributor

@hoangzinh Are you sure these steps are right? I'm not able to reproduce the issue when following them. This is what I see in the #admins room:

Image

@melvin-bot melvin-bot bot removed the Overdue label Apr 21, 2025
@hoangzinh
Copy link
Contributor Author

Oh, I realize I faced a different bug; LHN now displays the previous message after step 6. cc @nkdengineer if you face same issue as me or @yuwenmemon

Screen.Recording.2025-04-23.at.18.29.18.mov

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2025
Copy link

melvin-bot bot commented Apr 29, 2025

@yuwenmemon Still overdue 6 days?! Let's take care of this!

@hoangzinh
Copy link
Contributor Author

I tried again today and have same result #60154 (comment). cc @nkdengineer @yuwenmemon

@hoangzinh
Copy link
Contributor Author

I feel we can continue the process with your PR @nkdengineer. Because LHN now displays the previous message, it seems like a different bug. Wdyt?

@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 29, 2025

Sorry for the delay here. It's very late in my timezone now. I'll give an update tommorrow

@yuwenmemon
Copy link
Contributor

Sounds good @nkdengineer let me know if you think anything needs to be done on my end.

@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2025
@nkdengineer
Copy link
Contributor

I feel we can continue the process with your PR @nkdengineer. Because LHN now displays the previous message, it seems like a different bug. Wdyt?

@yuwenmemon @hoangzinh I can't reproduce the bug in the OP and completely agree with @hoangzinh here

@melvin-bot melvin-bot bot added the Overdue label May 5, 2025
Copy link

melvin-bot bot commented May 6, 2025

@yuwenmemon Huh... This is 4 days overdue. Who can take care of this?

@yuwenmemon
Copy link
Contributor

yuwenmemon commented May 6, 2025

@nkdengineer so what does that mean? What are the next steps as you see it?

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2025
@nkdengineer
Copy link
Contributor

I feel we can continue the process with your PR @nkdengineer. Because LHN now displays the previous message, it seems like a different bug. Wdyt?

As @hoangzinh mentioned here, this is a different bug. Then we'll continue the process in my previous PR @yuwenmemon

@melvin-bot melvin-bot bot added the Overdue label May 9, 2025
Copy link

melvin-bot bot commented May 12, 2025

@yuwenmemon Eep! 4 days overdue now. Issues have feelings too...

@hoangzinh
Copy link
Contributor Author

Hi team, I'm going to close this issue as it seems we don't need it anymore. Feel free to reopen it if you don't think so.

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants