[Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.50-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729117570646089

Action Performed:

1. Log in as user A
2. Go to workspace settings
3. Click "share" and copy the URL
4. Open the URL and login with different account user B
5. Log in back to user A and go to #admin room of the workspace

Expected Result:

System message should be user B requested to join user A workspace

Actual Result:

user B requested to join the workspace (invited by user A).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851379795160737664
• Upwork Job ID: 1851379795160737664
• Last Price Increase: 2024-10-29
• Automatic offers:
• nkdengineer | Contributor | 104682613

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

user B requested to join the workspace (invited by user A).

What is the root cause of that problem?

The action of this report Action is ACTIONABLEJOINREQUEST and we are not handling this action in the front-end.

What changes do you think we should make in order to solve the problem?

1. We should create new translation key for this action

        joinRequest: ({user, workspaceName}: {user: string, workspaceName: string} ) => ` ${user} requested to join ${workspaceName}`,

2. Create a util to get the join request message in ReportUtils

function getJoinRequestMessage(reportAction: ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST>) {
    return Localize.translateLocal('joinRequest', {user: ..., workspaceName: ...});
}

3. Do the same way as we do for other actions to add a case for the join request in other places

In ReportActionItem here

else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) {
    children = <ReportActionItemBasicMessage message={ReportUtils.getJoinRequestMessage(action)} />;
}

In OptionsListUtils.ts here

if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) { 
   return getJoinRequestMessage(parentReportAction); 
} 

In ContextMenuActions.tsx here

else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) { 
     const displayMessage = ReportUtils.getJoinRequestMessage(reportAction); 
     Clipboard.setString(displayMessage); 

What alternative solutions did you explore? (Optional)

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@anmurali 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851379795160737664

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[hoangzinh]

@nkdengineer's proposal looks good to me. Please ensure we also cover the thread case

App/src/libs/ReportUtils.ts

Line 3731 in 3657a67

if (isChatThread(report)) {

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @AndrewGable, @hoangzinh, @zanyrenney, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hoangzinh]

Quick updates: Still waiting for @AndrewGable to work on BE changes

[melvin-bot]

@AndrewGable, @hoangzinh, @zanyrenney, @nkdengineer, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[hoangzinh]

@AndrewGable @zanyrenney can someone please reopen this issue? It seems we're still working on it. I created an issue for BE change here but it's moved to somewhere https://github.com/Expensify/App/issues/56534

[hoangzinh]

@AndrewGable Can you share the status of this issue?

[AndrewGable]

It's completed and on production since March 6th, sorry forgot we moved it to a private repository.

[hoangzinh]

Cool. Thanks @AndrewGable. @nkdengineer you can start to resume your PR.

[nkdengineer]

@hoangzinh we have a follow up PR here

[hoangzinh]

@AndrewGable, we found another BE issue and are seeking your help on this. Let us know your thoughts

#58897 (comment)

[AndrewGable]

Can you please create a new backend issue using the template we used before? And link it here? Thank you!

[hoangzinh]

@AndrewGable @nkdengineer feel free to check out this GH issue for the BE bug above #60154

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: the system message when someone requests to join a workspace #58897

If no regressions arise, payment will be issued on 2025-05-27. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@hoangzinh @zanyrenney @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]