[Due for payment 2025-04-28] [Due for payment 2025-04-25] Update CreateAdminIssuedVirtualCard and CreateExpensifyCard for domain cards

[puneetlath]

As discussed here, as part of the Cross Compatible Corporate Cards project, we need to update the CreateAdminIssuedVirtualCard and CreateExpensifyCard API commands to pass the domainAccountID when we are using domain cards instead of workspace cards.

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[puneetlath]

No design needed. There's no UI for this.

[koko57]

@puneetlath I opened a draft PR (I will open it after BE changes and #59887 is merged)
For issuing the virtual card it WORKS PROPERLY 🎉 - although I found a bug(???) - sometimes the magic code validation modal doesn't open, the confirmation step is closed and no request is sent.

For the physical card - it still creates the card for the workspace feed

[puneetlath]

although I found a bug(???) - sometimes the magic code validation modal doesn't open, the confirmation step is closed and no request is sent.

That's weird! Does that seem to be a front-end issue? Or is the back-end not returning the right thing consistently?

For the physical card - it still creates the card for the workspace feed

Yep, that's expected. I haven't finished updating the back-end to support the new domainAccountID param.

[koko57]

That's weird! Does that seem to be a front-end issue? Or is the back-end not returning the right thing consistently?

Not sure. I can check it when testing the flow before opening the PR

[puneetlath]

@koko57 just FYI when we are calling CreateExpensifyCard for domain cards we should send the domainAccountID and send an empty policyID.

[koko57]

@puneetlath is the BE change for CreateAdminIssuedVirtualCard ready?

[puneetlath]

Yes, it should be live!

[puneetlath]

Wait, what we discussed here was that CreateAdminIssuedVirtualCard already accepts the domainAccountID, so no update is needed. But I did update CreateExpensifyCard to accept domainAccountID for physical cards. And that change is live.

[koko57]

@puneetlath PR ready for review: #59996

I also fixed a problem with deactivating cards - it didn't work for domain cards and a problem with the Expensify card page being rendered not properly - the Empty Cards State wasn't shown, empty card list was displayed intead, the loader wasn't displayed while loading

[puneetlath]

Ok great! @DylanDylann can you take the first round of review?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/59945 update api calls for expensify cards #59996

If no regressions arise, payment will be issued on 2025-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/59945 update api calls for expensify cards #59996

If no regressions arise, payment will be issued on 2025-04-28. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[johncschuster]

Payment Summary (to be issued after regression window has passed)

Contributor: @koko57 does not require payment (Contractor)
Contributor+: @DylanDylann owed $250 via NewDot

@DylanDylann please complete the above BZ Checklist when you get a moment. Thank you!

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug: New feature

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: New feature

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

PREREQUISITES: domain cards enabled on a policy

Test:

1. Go to Workspaces -> Your Workspace (with domain cards) -> Expensify Card
2. Try to issue both a virtual and a physical card (the same way it's done for Expensify Cards)
3. Verify that the cards are issued with no errors and they are displayed in the card list
4. Try to deactivate a domain card - it should work like for the workspace cards.

Do we agree 👍 or 👎

[johncschuster]

Thank you! Please request payment from here!