Skip to content

Expensify card - The issue card flow error displays after issuing a card #60407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 8 tasks
jponikarchuk opened this issue Apr 17, 2025 · 12 comments
Closed
5 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.29-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new behaviou
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5941233
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Log in with a new account
  3. Select the onboarding Manage my team's expense - 1-10 employees
  4. Navigate to Workspace settings
  5. Enable Expensify Card
  6. Click on the Expensify Card feature
  7. Click on the issue card
  8. Complete all the flow issues on a card until the MC step
  9. Enter the MC

Expected Result:

The app should ask for the add bank account before and update the currency of the Workspace to USD if not

Actual Result:

After enabling the Expensify Card feature, can click on the issue card button right away without adding a bank account and after entering MC display an error message

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

Image

View all open jobs on GitHub

@jponikarchuk jponikarchuk added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 17, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 17, 2025
Copy link

melvin-bot bot commented Apr 17, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 17, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@techievivek
Copy link
Contributor

I only see this PR that has some related changes #59887 cc @DylanDylann @koko57, do you mind taking a look at the GH, thanks.

@joekaufmanexpensify
Copy link
Contributor

Seems like we might have identified the offender, but LMK if i can help in the interim!

@koko57
Copy link
Contributor

koko57 commented Apr 17, 2025

@techievivek yes, it's my bad - looks like the account was not configured for the Expensify cards and it was shown the empty card list page instead Empty State, so the user was able to go through the flow and the error was thrown - it will be fixed in my next PR #59996

@koko57
Copy link
Contributor

koko57 commented Apr 17, 2025

@joekaufmanexpensify @techievivek PR was merged

@techievivek
Copy link
Contributor

Assigning to @puneetlath since he will be coordinating with applause team to confirm the issue is fixed.

@puneetlath
Copy link
Contributor

Fix CP'd. Asking applause for a re-test.

@kavimuru
Copy link

Bug is not reproducible

bandicam.2025-04-17.19-58-11-860.mp4

@puneetlath
Copy link
Contributor

great!

@github-actions github-actions bot removed the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants