-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-04-07] Android - Onboarding - Task name briefly changes to "Chat Report" in Concierge chat #58269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @jliexpensify ( |
Triggered auto assignment to @nkuoch ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@Krishna2323 This is a regression caused by your PR |
@linhvovan29546 thanks. @nkuoch please assign me. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The task name briefly changes to "Chat Report" before reverting. What is the root cause of that problem?This is not a regression from #54165, but actually a bug that only got caught after #54165 is merged. In task preview, we set the task name as:
With Initially When clicking on a task report that is not yet on Onyx, we start calling App/src/libs/actions/Report.ts Line 868 in 16d64f1
This makes What changes do you think we should make in order to solve the problem?We should prioritize What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?None What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
No need to block the deploy on this one |
This PR will fix the issue. Waiting for @mananjadhav's review. |
Cool, ty! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-04-07. 🎊 For reference, here are some details about the assignees on this issue:
|
@mananjadhav @jliexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Linked PR was deployed to production few hours ago. |
Bumping @mananjadhav for a checklist |
Payment Summary
|
Payment Summary
BugZero Checklist (@jliexpensify)
|
Bump @mananjadhav for the checklist! |
@jliexpensify, I think @mananjadhav also doesn't require any payment for this task, as he was the author of the regression-causing PR. Please correct me if there's a different rule for C+. |
Oh right - that makes sense! Apologies - I thought he was assigned to review separately, I didn't realise he was the initial C+ for the regression. |
I'll close this out then - I don't believe we need a checklist as it's a regression, but please correct me if I'm wrong! |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9.1.11-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Other
Action Performed:
“Manage my team’s expenses”
“1-10 employees”
“None”
Expected Result:
The task name should remain unchanged when tapped.
Actual Result:
The task name briefly changes to "Chat Report" before reverting.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6768323_1741764501575.Screenrecorder-2025-03-12-12-53-57-120.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @jliexpensifyThe text was updated successfully, but these errors were encountered: