-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Due for payment 2025-03-21] [$500] Feature request : Upgrade task titles with markdown rendering #53175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Triggered auto assignment to @muttmuure ( |
@muttmuure Eep! 4 days overdue now. Issues have feelings too... |
Job added to Upwork: https://www.upwork.com/jobs/~021863958075863531330 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Hm, why hasn't this had any proposals? Also, why is the job listing "private"? |
Upwork job price has been updated to $500 |
The job shows as public to me in Upwork. |
Edited by proposal-police: This proposal was edited at 2024-12-07 22:35:47 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Feature request : Upgrade task titles with markdown rendering What is the root cause of that problem?New feature What changes do you think we should make in order to solve the problem?
Test Branch
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?What alternative solutions did you explore? (Optional)
ResultMonosnap.screencast.2024-12-07.10-42-17.mp4 |
@mananjadhav 👀 plz on the proposal above. Thx |
Yes I had reviewed the proposal partially on the weekend. The proposal looks good, minor code changes and other areas to make updates can be covered in the implementation. 🎀 👀 🎀 |
Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@JmillsExpensify Vic is out, can you please wrap this issue up? Thx |
@JmillsExpensify Quick bump on this one.
Also @roryabraham if you got a chance to go through this comment. |
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this? |
This appears ready for payout. I think it would be reasonable to increase the bounty for this one. @mananjadhav What price do you think is fair? |
Waiting for final payment amount. |
Hi everyone, After evaluating the time and effort we’ve put into this feature, I feel that $1500 would be a fair amount. Even after the initial implementation, we had to address several regressions — many of which were quite nuanced — and we put a lot of effort and time into resolving them as well. Honestly, during the time I was working on this PR, I lost track of posting new proposals, which felt like a significant setback for me personally, and I’m still trying to get back into the flow. That said, I completely understand if any other amount feels more appropriate from a broader perspective — I’m comfortable with that too. Honestly, I even feel a little weird putting a number to it because it was a big learning experience for me, and I'm really grateful for the opportunity to work on this. Thanks a lot for considering! 🙏 cc: @mananjadhav |
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this? |
$1500 seems reasonable to me as well 👍🏼 |
I agree with @Krishna2323's assessment. @JmillsExpensify can you help with the same? |
@VictoriaExpensify, since it has been decided to increase the bounty on this issue, I just wanted to clarify that I have already received $500. #53175 (comment) |
Thanks for the update @Krishna2323. I think it's @JmillsExpensify who's going to take care of the payout here. |
Contributor: @Krishna2323 paid $1000 via Upwork (alreadypaid $500 here. Payment was on same job, $1k was added as a bonus ) Do we need regression tests here? Seems like we would. cc @mananjadhav |
Yes. I'll need some time to build the regression tests. Quick question, do we have any set of regression tests for markdown fields? Ideally we would need the same tests here as well. |
Thanks @mallenexpensify for the quick assist! |
These are the tests I see when I search ![]() Can you access TestRail? Looks like you have read-only access @mananjadhav do we have any set of regression tests for markdown fields? |
Ohh I forgot. I'll have to check. I'll check this on the weekend and try to build the test cases. |
$1500 approved for @mananjadhav |
@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too... |
@JmillsExpensify Still overdue 6 days?! Let's take care of this! |
I am copying the tests from individual PRs. Should have them ready by today/tomorrow. |
@JmillsExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
✅ Regression Test Proposal
@mallenexpensify Can you please add this to the Task title regression test suite? Once added we're good to close this one. |
Regression tests created so closing this one out. |
Uh oh!
There was an error while loading. Please reload this page.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: New Feature
Reproducible in production?: New Feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): ts_external_expensify_convert
Background: The primary use of tasks today is Concierge assigning a specific set of onboarding task to the user. Each task currently has a numbered list of steps, generally ending with a link we want them to click. However, we see that some users don't realize the task can be clicked, meaning they don't see the instructions, meaning they don't click the link.
Problem: When new users don't realize the task title is clickable, they don't see the instructions, and thus don't do the call to action.
Solution: Please render task names using the same markdown>html processing as we do normal comments, to allow hyperlinks to be put into titles, in order to shorten the path to the CTA to one click. In other words, make task titles work like task descriptions:
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: