Skip to content

[Due for payment 2025-04-08] [Report Creation UI] Add empty State to Expense View and Expense Preview #57654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mountiny opened this issue Mar 2, 2025 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Mar 2, 2025

Implement this section of the design doc

Also this section of the doc to cover the carousel

@SzymczakJ @sumo-slonik

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
Copy link

melvin-bot bot commented Mar 2, 2025

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 2, 2025
@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@trjExpensify trjExpensify moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Mar 4, 2025
@trjExpensify
Copy link
Contributor

trjExpensify commented Mar 6, 2025

Just confirming as the title alludes to it, but will this issue will take care of this section of the doc as well? https://docs.google.com/document/d/1L3bsKjf1xxjTOfColJFMtunCYeBArWJ12CnZJyaDHKQ/edit?tab=t.0#heading=h.4rhsvezdvbjb

@mountiny
Copy link
Contributor Author

mountiny commented Mar 6, 2025

Updated to make it clearer

@trjExpensify
Copy link
Contributor

Awesome!

@allgandalf
Copy link
Contributor

please remove my assignment from here as @DylanDylann is reviewing this one, why can't i unassign myself 😿

@trjExpensify
Copy link
Contributor

Done!

@SzymczakJ
Copy link
Contributor

FYI I'm going OOO for the next week and I will be back on 25.03.. @sumo-slonik will continue working on this issue, while I'm away.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 1, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] Add empty State to Expense View and Expense Preview [Due for payment 2025-04-08] [Report Creation UI] Add empty State to Expense View and Expense Preview Apr 1, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-08. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 1, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@trjExpensify
Copy link
Contributor

We won't have any payments here, are we good to close @SzymczakJ @mountiny @DylanDylann?

@mountiny
Copy link
Contributor Author

mountiny commented Apr 1, 2025

Yeah I think we can close and handle regression tests at the end of the project. We have follow up tasks created too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

7 participants