Skip to content

[Due for payment 2025-04-08] [Report Creation UI] Create report - There are two expense previews after creating a new report #58426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 of 16 tasks
mitarachim opened this issue Mar 14, 2025 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Mar 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User has at least one workspace
  1. Go to staging.new.expensify.com
  2. Go to FAB > Create report.
  3. Go back to Inbox.
  4. Open the workspace chat.

Expected Result:

There will be only one expense preview.

Actual Result:

There are two expense previews after creating a new report.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHubIf you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User has at least one workspace
  1. Go to staging.new.expensify.com
  2. Go to FAB > Create report.
  3. Go back to Inbox.
  4. Open the workspace chat.

Expected Result:

There will be only one expense preview.

Actual Result:

There are two expense previews after creating a new report.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6770213_1741918795209.20250314_101809.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Mar 14, 2025
Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Mar 14, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Mar 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@jliexpensify
Copy link
Contributor

Hmm, how do you create a Report? I'm on Staging v1.13-0 but don't see that option cc @techievivek

@jliexpensify
Copy link
Contributor

But I don't think this is a deploy blocker.

@techievivek
Copy link
Contributor

This is behind a beta, so we can demote it.

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Mar 14, 2025
@techievivek
Copy link
Contributor

CC @SzymczakJ

@SzymczakJ
Copy link
Contributor

Assign me to this one, we will fix it in next PR touching Create report flow.

@mountiny mountiny changed the title Create report - There are two expense previews after creating a new report [Report Creation UI] Create report - There are two expense previews after creating a new report Mar 14, 2025
@mountiny mountiny assigned mountiny and unassigned techievivek Mar 14, 2025
@mountiny
Copy link
Contributor

Thanks! Going to handle this as its from a project I manage with Carlos

@luacmartins luacmartins self-assigned this Mar 14, 2025
@trjExpensify trjExpensify changed the title [Report Creation UI] Create report - There are two expense previews after creating a new report [Hold #57654] [Report Creation UI] Create report - There are two expense previews after creating a new report Mar 19, 2025
@trjExpensify
Copy link
Contributor

Going to be taken care of in the PR for #57654, popped a hold in the title to reflect that.

@sumo-slonik
Copy link
Contributor

sumo-slonik commented Mar 20, 2025

I managed to fix it while working on the empty state PR. ✅

@trjExpensify
Copy link
Contributor

Niceee!

@mountiny
Copy link
Contributor

So we can more the hold from the title I assume

@jliexpensify
Copy link
Contributor

I can change it to reflect the new PR

@melvin-bot melvin-bot bot added the Overdue label Mar 21, 2025
@jliexpensify jliexpensify changed the title [Hold #57654] [Report Creation UI] Create report - There are two expense previews after creating a new report [Hold FOR #58795] [Report Creation UI] Create report - There are two expense previews after creating a new report Mar 21, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Mar 21, 2025
@trjExpensify
Copy link
Contributor

Going to drop the hold, as it's linked to the PR and will take care of this bug.

@trjExpensify trjExpensify changed the title [Hold FOR #58795] [Report Creation UI] Create report - There are two expense previews after creating a new report [Report Creation UI] Create report - There are two expense previews after creating a new report Mar 27, 2025
@sumo-slonik
Copy link
Contributor

It seems to me that this should already be fixed.

@jliexpensify jliexpensify added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Mar 31, 2025
@jliexpensify
Copy link
Contributor

Since this is behind a beta, I've asked QA to re-test

@kavimuru
Copy link

Unable to reproduce.

58795.web.mp4

@mountiny
Copy link
Contributor

Perfect, going to close then thanks

@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Mar 31, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 1, 2025
@melvin-bot melvin-bot bot changed the title [Report Creation UI] Create report - There are two expense previews after creating a new report [Due for payment 2025-04-08] [Report Creation UI] Create report - There are two expense previews after creating a new report Apr 1, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 1, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-08. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Apr 1, 2025

@luacmartins / @mountiny @jliexpensify @sumo-slonik / @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
Development

No branches or pull requests

9 participants