[Due for payment 2025-04-14] [$250] Ensure we only have one error message show for forms that have only one input

[dylanexpensify]

Problem: moving into a newDot world, we've been able to make a lot of our forms shorter and with fewer inputs per form. When users make an input that isn't the correct format for the form an error is thrown both in the input and at the bottom of the form. When they click on the hyperlink to fix the error, it autofocuses them to the input in question. This can result in confusion though for a user when multiple error messages show for a form that has only one input.

Solution: remove footer errors when only one input exists in a form. This removes any confusion for a user who might click on the hyperlink and be brought to the only input.

Next steps:

• Review all forms we have in product for NewDot
• For all that have only one input, remove the footer error message

Mocks

cc @Expensify/design

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885281718152248847
• Upwork Job ID: 1885281718152248847
• Last Price Increase: 2025-02-07
• Automatic offers:
• shubham1206agra | Contributor | 106076444

Issue Owner

Current Issue Owner: @dylanexpensify

[dylanexpensify]

Coming from this internal slack post for visibility for internal members.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ensure we only have one error message show for forms that have only one input

What is the root cause of that problem?

Improvement Task

What changes do you think we should make in order to solve the problem?

• Review all forms we have in product for NewDot

For this, we will review all the usage of FormProvider component and determine whether we should show or hide the Fix alert

• For all that have only one input, remove the footer error message

After doing the previous step, we will use pre-existing prop named shouldHideFixErrorsAlert, which can be put on FormProvider component.

One example of existing usage -

App/src/pages/workspace/distanceRates/PolicyDistanceRateEditPage.tsx

Line 87 in b59f23b

shouldHideFixErrorsAlert

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since this is an UI change

What alternative solutions did you explore? (Optional)

[dannymcclain]

Added a mock to OP to make it a little more clear what the expected outcome would look like.

[melvin-bot]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

NICE! Thanks @dannymcclain!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885281718152248847

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

@rojiphil, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rojiphil]

Will review today

[rojiphil]

@shubham1206agra proposal to use shouldHideFixErrorsAlert for all forms having only one input should solve this issue. Proposal LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dylanexpensify]

Nice! Rory to confirm

[dylanexpensify]

bump le @roryabraham 🙇‍♂

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dylanexpensify]

@shubham1206agra mind giving an update?

[shubham1206agra]

Waiting for approval from @roryabraham

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide fix form alert for single form input #57647

If no regressions arise, payment will be issued on 2025-04-14. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Contributor)

[dylanexpensify]

@roryabraham le bump!

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[dylanexpensify]

Payment summary:

Contributor: @rojiphil $250 via Upwork
Contributor+: @shubham1206agra $250 via NewDot

Please apply/request!

[dylanexpensify]

@shubham1206agra sent new offer!

[shubham1206agra]

@dylanexpensify My payment should be on NewDot.

[rojiphil]

Thanks @dylanexpensify for the payment summary. I have requested in ND.

[garrettmknight]

$250 approved for @shubham1206agra

[garrettmknight]

$250 approved for @rojiphil