Distance Expense - Missing "Fix Error" Link in Distance Expense Creation Modal

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5966670&group_by=cases:section_id&group_id=294997&group_order=asc
Email or phone of affected tester (no customers): n.a
Issue reported by: Applause Internal Team
Device used: win11/chrome
App Component: Money Requests

Action Performed:

Precondition: a collect workspace is set up

Steps:

1. Open the link www.staging.new.expensify.com
2. Logged in as employee
3. Click FAB button
4. Click "Create Expense"
5. Select Distance option
6. Click start
7. Enter any text that will not return an address
   8.Observe that there is no "Fix Error" link displayed at the bottom of the modal.

Expected Result:

• The "Fix Error" link should be displayed at the bottom of the modal.
• Users should be able to click on it, redirect to the start field, and remain focused to edit the invalid address.

Actual Result:

The "Fix Error" link does not appear at the bottom of the modal when an invalid address is entered.
reproducible on mweb, hybrid android and IOS

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6807317_1745084605687.Recording__913.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Expected #57647

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance Expense - Missing "Fix Error" Link in Distance Expense Creation Modal

What is the root cause of that problem?

We dont display the "Fix Error" link on single input form

And there is no focus on the input field after error message displayed

What changes do you think we should make in order to solve the problem?

Auto-focus the input field after the error message is displayed for single input form

App/src/components/FormAlertWithSubmitButton.tsx

Line 143 in 7a42c6a

onPress={onSubmit}

On here, execute onFixTheErrorsLinkPressed after onSubmit completed

Or alternatively, create a new function to focus the input field if there is an error and if it is a single input form, and execute that new function after onSubmit

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[shubham1206agra]

This is not a bug. The fix error link was removed in #55649

cc @dylanexpensify

[lschurr]

Thanks! Closing