Confusing error on adding self account to new chat or group

[akshayasalvi]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB
2. Click on New Chat or New Group chat
3. Enter the logged-in user's email in the search field
4. Click on Add you'll see a confusing error.

Expected Result:

1. It should throw a more user friendly error.
2. It shouldn't show up logged in user account when searching with self account.

Actual Result:

Shows an error: "500 need to pass atleast 2 accounts"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[akshayasalvi]

Proposed Solution

In OptionListUtils.js there's a handling missing to hide logged in account during search.

let userToInvite = null;
if (searchValue
    && recentReportOptions.length === 0
    && personalDetailsOptions.length === 0
    && _.every(selectedOptions, option => option.login !== searchValue)
    && ((Str.isValidEmail(searchValue) && !Str.isDomainEmail(searchValue)) || Str.isValidPhone(searchValue))
    && (searchValue !== CONST.EMAIL.CHRONOS || Permissions.canUseChronos(betas)
    
    && searchValue !== currentUserLogin)  // NEW ADDITION for FIX
) {

Add the searchValue !== currentUserLogin to the userToInvite block's in the code.

Second way, is to make a more reader friendly errors such as "Cannot chat with own/self account"

[johncschuster]

I have reproduced this by being logged in as [email protected] and attempting to create a New Chat with [email protected]. 👍

[MelvinBot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[SofiedeVreese]

Posted to Upwork: https://www.upwork.com/jobs/~0107be2dcefa1bc350

Assigning a CME now to review @akshayasalvi 's proposal.

[MelvinBot]

Triggered auto assignment to @NikkiWines (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[SofiedeVreese]

hey @NikkiWines please see @akshayasalvi 's proposal above

[aman-atg]

I think this will be solved after closing of #4325.

[Julesssss]

Hi @akshayasalvi, thanks for raising the issue and suggesting a proposal.

By coincidence, we have just merged the fix you mentioned to solve another issue. I'm going to close this as a duplicate.