[Hold for payment on Thurs 26th Aug] User's Profile is shown in searches when email/phone is entered

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to new expensify
2. Search for your email/phone
3. Your own profile will appear as an option

Expected Result:

Current User shouldn't appear as an option

Actual Result:

bug.mp4

Workaround:

None.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Expensify/Expensify Issue URL: N/A
Upwork job link https://www.upwork.com/jobs/~015c092db274787ca2

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal

Explaination

It's happening because we're not checking if the searchValue is User's one of the logins or not

Solution

    // eslint-disable-next-line no-use-before-define
    const isInvalidLogin = isCurrentUser({login: searchValue});
    let userToInvite = null;
    if (searchValue && !isInvalidLogin

• Integrating the above code after line 464 will fix the issue

  App/src/libs/OptionsListUtils.js

  Lines 464 to 472 in f856107

  	let userToInvite = null;
  	if (searchValue
  	&& recentReportOptions.length === 0
  	&& personalDetailsOptions.length === 0
  	&& _.every(selectedOptions, option => option.login !== searchValue)
  	&& ((Str.isValidEmail(searchValue) && !Str.isDomainEmail(searchValue)) || Str.isValidPhone(searchValue))
  	&& (searchValue !== CONST.EMAIL.CHRONOS || Permissions.canUseChronos(betas))
  	) {

[rdjuric]

Looks similar to #4011

[aman-atg]

@rdjuric It isn't.

We're already trying to exclude the User from the OptionList as you can see below

App/src/libs/OptionsListUtils.js

Lines 380 to 381 in 87cbc24

	// Always exclude already selected options and the currently logged in user
	const loginOptionsToExclude = [...selectedOptions, {login: currentUserLogin}];

But that approach fails when user directly searches for it's login. Then we're making API calls which are failing because it's an unexpected scenario.

[MelvinBot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Reproduced (note: your own profile only appears once you've typed the full phone number/email address)

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[stitesExpensify]

Hi @michaelhaxhiu can we hire @aman-atg to fix this please?

[MelvinBot]

@michaelhaxhiu, @stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

Sorry for the wait. Posted the job here - https://www.upwork.com/jobs/~015c092db274787ca2

@aman-atg can you propose to handle the job on Upwork and then we can hire you?

[michaelhaxhiu]

Also, this issue exists across all platforms right?

I can't reproduce this on iOS actually. Can you please clarify the affected platforms before beginning work @aman-atg?

[aman-atg]

I tested this on android, web and android web and the searching logic is same for all so it should also happen on iOS/Desktop.
I can't test on those two, so I can't confirm.

[michaelhaxhiu]

Please ⏸️ for a moment. cc @mallenexpensify

[MelvinBot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Taking off HOLD, @Julesssss can you review @aman-atg proposal please?

[Julesssss]

Hi @aman-atg the solution seems correct, but I think instead we should add that condition inline to match the rest of the logic:

if (searchValue 
     && recentReportOptions.length === 0 
     && personalDetailsOptions.length === 0 
     && !isCurrentUser({login: searchValue})
     ...

@mallenexpensify please go ahead and hire @aman-atg

[aman-atg]

Thanks @Julesssss.
Will follow the above approach while submitting the PR.

[Christinadobrzyn]

Hey @mallenexpensify This issue has the Help Wanted label, I believe it can be removed but can you confirm and remove it if that's true?

[mallenexpensify]

Yes, thank for the 👀 and ping @Christinadobrzyn , label removed

[mallenexpensify]

chill Melvin...

[mallenexpensify]

Just deployed to production today but paying because it's been 17 days since merge (and our policy at the time was to pay a week after merge). Bonus added for reporting issue.

[mallenexpensify]

Forgot to close last week...