[HOLD for payment 2024-02-14] [$125] Web - Profile icon and wrench at the bottom have the same tooltips

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.36-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login in to New Expensify
2. Hover over Profile icon
3. Hover over wrench icon at the bottom
4. Note that the tooltips are the same

Expected Result:

The tooltips should differ, and describe the pages to which they lead.

Actual Result:

For both icons the tooltip is: "Settings". Even though one leads to Account Settings, and the other to Workspaces Settings.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365300_1706906365717.2024-02-02_21-26-46.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011391fcb0d4fa84f7
• Upwork Job ID: 1753532395165429760
• Last Price Increase: 2024-02-02
• Automatic offers:
• alitoshmatov | Reviewer | 28142751

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011391fcb0d4fa84f7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Upwork job price has been updated to $125

[luacmartins]

Yes, it comes from the ideal nav PR. I don't think this is a blocker. Demoting and making it external so a contributor can work on it.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Profile icon and wrench at the bottom have the same tooltips

What is the root cause of that problem?

The main problem with issue is that we use the same text for 2 tooltips

What changes do you think we should make in order to solve the problem?

To fix this issue we can update the text here (Workspaces Settings)

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Line 66 in b724a86

<Tooltip text={translate('common.settings')}>

And here (Account Settings)(already have a translation)

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Line 61 in 0853f6c

tooltipText={translate('common.settings')}

What alternative solutions did you explore? (Optional)

NA

[aeioual]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Profile icon and wrench at the bottom have the same tooltips

What is the root cause of that problem?

We pass common.settings as tootip text at PressableAvatarWithIndicator for profile avatar:

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Lines 59 to 61 in 0853f6c

	<AvatarWithIndicator
	source={UserUtils.getAvatar(currentUserPersonalDetails.avatar, currentUserPersonalDetails.accountID)}
	tooltipText={translate('common.settings')}

What changes do you think we should make in order to solve the problem?

We need to substitute the tootTipText with tooltipText={translate('profilePage.profile')}

The setting page is as intended so no change over there

What alternative solutions did you explore? (Optional)

N/A

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Profile icon and wrench at the bottom have the same tooltips.

What is the root cause of that problem?

We used the common.settings translation for the tooltipText prop in the PressableAvatarWithIndicator component.

App/src/pages/home/sidebar/PressableAvatarWithIndicator.js

Lines 59 to 61 in 3ab4e6e

	<AvatarWithIndicator
	source={UserUtils.getAvatar(currentUserPersonalDetails.avatar, currentUserPersonalDetails.accountID)}
	tooltipText={translate('common.settings')}

It is also used in the BottomTabBar component, thus will display identical text in the tooltip.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 66 to 67 in 3ab4e6e

	<Tooltip text={translate('common.settings')}>
	<PressableWithFeedback

What changes do you think we should make in order to solve the problem?

Since the other components depend on the PressableAvatarWithIndicator component, the appropriate replacement common.settings would be initialSettingsPage.account.

App/src/languages/en.ts

Lines 821 to 822 in 3ab4e6e

	accountSettings: 'Account Settings',
	account: 'Account',

tooltipText={translate('initialSettingsPage.account')}

What alternative solutions did you explore? (Optional)

If it is more appropriate to display Account Settings than Account, we can then use the initialSettingsPage.accountSettings translation.

[twisterdotcom]

@alitoshmatov this seems pretty simple. Can we get one of these moving?

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Amarparab2024 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[alitoshmatov]

Looks like proposal is already selected without C+. I am assuming PR review by C+ is still required. Unassign me if review is not needed

[aeioual]

PR is up, also applied for the job on upwork :)

[aeioual]

also @luacmartins , similar issue, 2 has compensation of $500/$250, so i was wondering whether this is also eligible for that bounty? 🤔

[luacmartins]

Unfortunately not, and I think we should have changed the bounty for that issue too

[aeioual]

No worries :), thanks for the clarification

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix]: Updated tooltip text #35828

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @Amarparab2024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

@Amarparab2024 can you share your Upwork profile link please?

[aeioual]

@twisterdotcom sure thing, here it is:

https://www.upwork.com/freelancers/~018868fbbe5334b29e

[aeioual]

also @luacmartins , similar #35507, #35683 has compensation of $500/$250, so i was wondering whether this is also eligible for that bounty? 🤔

referring to the comments above, if possible can you please match the bounty of this issue same at par with similar other mentioned issues :)

If not then no problem this is just fine

[twisterdotcom]

I think this will remain as Carlos agreed here: #35728 (comment)

[aeioual]

No problem :)

[twisterdotcom]

@alitoshmatov I need you to accept your offer: https://www.upwork.com/nx/wm/offer/28142751
@Amarparab2024 I need you to accept your offer: https://www.upwork.com/nx/wm/offer/100905317

[twisterdotcom]

Payment Summary:

• @alitoshmatov paid $125 here - C+
• @Amarparab2024 paid $125 here - Contributor

We do not need a Test for this.