[HOLD for payment 2024-02-14] [$500] Request money - Missing Tooltip for "Cancel" Icon Linked to "Request money, get $250"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1, Navigate to FAB (Floating Action Button) > Request Money > Add Amount
2, At the bottom, observe that the "Cancel" icon associated with "Request money, get $250" lacks a tooltip

Expected Result:

The "Cancel" icon associated with "Request money, get $250" should have a tooltip, similar to the Cancel Icon displayed when editing text in conversations

Actual Result:

The "Cancel" icon associated with "Request money, get $250" does not have a tooltip

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362757_1706727588598.q.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013fe88086e3f5b2fc
• Upwork Job ID: 1752773353838592000
• Last Price Increase: 2024-01-31

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013fe88086e3f5b2fc

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Cancel" icon associated with "Request money, get $250" does not have a tooltip

What is the root cause of that problem?

We don't wrap Cancel button by Tooltip component

App/src/components/ReferralProgramCTA.tsx

Lines 47 to 62 in 2d2ea11

	<PressableWithoutFeedback
	onPress={onCloseButtonPress}
	onMouseDown={(e) => {
	e.preventDefault();
	}}
	style={[styles.touchableButtonImage]}
	role={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={translate('common.close')}
	>
	<Icon
	src={Close}
	height={20}
	width={20}
	fill={theme.icon}
	/>
	</PressableWithoutFeedback>

What changes do you think we should make in order to solve the problem?

We should wrap Cancel button by Tooltip component like that

<Tooltip text={translate('common.close')}>
...
</Tooltip>

What alternative solutions did you explore? (Optional)

NA

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing tooltip for cancel icon

What is the root cause of that problem?

No tooltip component arount the icon on src/components/ReferralProgramCTA.tsx

What changes do you think we should make in order to solve the problem?

Add Tooltip around PressableWithoutFeedback on src/components/ReferralProgramCTA.tsx line 47

[mollfpr]

The proposal from @DylanDylann looks good to me!

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

❌ There was an error making the offer to @mollfpr for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @DylanDylann for the Contributor role. The BZ member will need to manually hire the contributor.

[JmillsExpensify]

@mollfpr Is paid via NewDot, so no Upwork offer is necessary. Offer sent to @DylanDylann.

[DylanDylann]

@mollfpr PR #35646 is ready to review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/35507: Missing tooltip close button #35646

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment (Needs manual offer from BZ)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr / @DylanDylann] Determine if we should create a regression test for this bug.
• [@mollfpr / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Contributor+: @mollfpr paid $500 via Expensify
• Contributor: @DylanDylann paid $500 via Upwork

BugZero Checklist (@JmillsExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1752773353838592000/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

Contributor has been paid out! @mollfpr Please complete the BZ checklist before requesting in Expensify. I'm going to close the issue in the meantime, though I'll circle back when I receive your request.

[mollfpr]

[@mollfpr / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I can't trace it back to the previous commit, probably the issue because we forgot to add a tooltip for the icon button.

[@mollfpr / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1708004231670919

[@mollfpr / @DylanDylann] Determine if we should create a regression test for this bug.
[@mollfpr / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think we don't need a specific regression test for this specific icon button. If we have guidance on how to handle creation an icon button.

[trjExpensify]

Confirming the payment summary here is correct: #35507 (comment)

$500 to @mollfpr for the C+ review.
$500 to @DylanDylann for the fix.

[JmillsExpensify]

$500 approved for @mollfpr based on confirmation above.