fix(button): don't needlessly overwrite title #8418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8417
Summary
In my application I set
title
attribute on the<calcite-button>
, but it wasn't being displayed because the shadow DOM's<button>
had an empty title attribute (title=""
) which was overwriting the title set on the calcite-button.Reproduction:
<button>
, and tooltip is visibleVideo reproduction:
out.mp4