Skip to content

fix(button): don't needlessly overwrite title #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Dec 11, 2023
Merged

fix(button): don't needlessly overwrite title #8385

merged 0 commits into from
Dec 11, 2023

Conversation

maxpatiiuk
Copy link
Member

In my application I set title attribute on the <calcite-button>, but it wasn't being displayed because the shadow DOM's <button> had an empty title attribute (title="") which was overwriting the title set on the calcite-button.

Reproduction:

  1. Codepen example
  2. Hover over the button - no tooltip is shown
  3. Remove the "title" attribute from the <button>, and tooltip is visible

Video reproduction:

out.mp4

@maxpatiiuk maxpatiiuk added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 8, 2023
@maxpatiiuk maxpatiiuk self-assigned this Dec 8, 2023
@maxpatiiuk maxpatiiuk requested a review from a team as a code owner December 8, 2023 22:39
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR, @maxpatiiuk!

Before proceeding, would you mind doing the following?

  1. Creating an issue so this goes through our verification workflow.
  2. Add an E2E test that provides coverage for this fix.

Let us know if you have any questions, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants