fix(list): changing filterText property will now update filtered items #7133

driskull · 2023-06-06T00:59:23Z

Related Issue: #6633

Summary

Depends on feat(filter): Add filter method #7127
Tidy's up tests and remove skipping.
Watches filterText property and calls filter method when it changes.
Calls filter method once the filterEl has been rendered.
Cleanup

#6633

…onents into dris0000/filter-method

# Conflicts: # packages/calcite-components/src/components/filter/filter.e2e.ts

jcfranco

🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍
🔍🔍📚📚📚🔍🔍📚📚🔍🔍🔍📚📚🔍🔍📚🔍🔍🔍📚🔍
🔍📚🔍🔍🔍🔍📚🔍🔍📚🔍📚🔍🔍📚🔍📚🔍🔍🔍📚🔍
🔍📚🔍🔍🔍🔍📚🔍🔍📚🔍📚🔍🔍📚🔍📚🔍🔍🔍📚🔍
🔍📚🔍🔍🔍🔍📚🔍🔍📚🔍📚🔍🔍📚🔍📚🔍🔍🔍🔍🔍
🔍🔍📚📚📚🔍🔍📚📚🔍🔍🔍📚📚🔍🔍📚📚📚🔍📚🔍
🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍🔍

This should be good to merge once the June (patch-only) release is done and after #7127 lands.

jcfranco · 2023-06-16T18:17:17Z

packages/calcite-components/src/components/list/list.e2e.ts

    expect(await list.getProperty("filteredItems")).toHaveLength(2);
    expect(await list.getProperty("filteredData")).toHaveLength(2);
    expect(await list.getProperty("filterText")).toBeUndefined();

    await filter.callMethod("setFocus");

-    const calciteListFilterEvent = page.waitForEvent("calciteListFilter");
+    const calciteListFilterEvent = list.waitForEvent("calciteListFilter");


✨🧹✨🏆

jcfranco · 2023-06-16T18:23:37Z

packages/calcite-components/src/components/list/list.tsx

+    this.updateListItems(emit);
+  }
+
+  private async performFilter(): Promise<void> {


Some naming suggestions: filter(), runFilter, refreshFilter(), updateFilter? Up to you.

jcfranco · 2023-06-16T18:27:41Z

packages/calcite-components/src/components/list/list.tsx

@@ -450,7 +477,7 @@ export class List implements InteractiveComponent, LoadableComponent {
    focusEl.setFocus();
  };

-  isNavigable = (listItem: HTMLCalciteListItemElement): boolean => {
+  private isNavigable = (listItem: HTMLCalciteListItemElement): boolean => {


Thanks for making these private. This reminds me to look for a rule to help enforce access modifiers on class members (these can affect whether they are exposed in Stencil's generated interfaces 🕵️).

github-actions · 2023-06-24T02:04:38Z

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.5.0</summary> ## [1.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-03) ### Features * **action-group:** Adds overlayPositioning property. ([#7366](#7366)) ([ca9f35a](ca9f35a)) * Allow sharing focus trap stacks via configuration global ([#7334](#7334)) ([934a19f](934a19f)) * Automatically import and define Calcite Components when importing their React wrapper ([#7185](#7185)) ([bf0ff67](bf0ff67)) * **block, block-section:** Add setFocus method ([#7208](#7208)) ([35d4bbb](35d4bbb)) * **block:** Improve block's content layout to allow scrolling ([#7367](#7367)) ([ecbf17b](ecbf17b)) * **color-picker:** Replaces thumb focus outline to rounded ([#7378](#7378)) ([d803980](d803980)) * **filter:** Add filter method ([#7127](#7127)) ([5a4283f](5a4283f)) * **flow:** Adds setFocus method ([#7252](#7252)) ([2472c58](2472c58)) * Improve focus behavior in components ([#7277](#7277)) ([ad9fbca](ad9fbca)) * **input-time-zone:** Add input-time-zone component ([#6947](#6947)) ([87bd496](87bd496)) * **list:** Add slots for filter actions ([#7183](#7183)) ([da07ab1](da07ab1)) * **list:** Add support for dragging items. ([#7109](#7109)) ([7324f70](7324f70)) * **menu-item:** Update spacing and icon layout ([#7381](#7381)) ([5659671](5659671)) * **navigation-logo:** Increase font-size of heading with no description ([#7081](#7081)) ([355e101](355e101)) * **switch:** Updates focus outline to be rounded ([#7390](#7390)) ([2616b82](2616b82)) * **text-area:** Provide additional context for AT users when character limit exceeds ([#7299](#7299)) ([c5678eb](c5678eb)) * **text-area:** Provide additional context for AT users when character limit exceeds ([#7412](#7412)) ([c1af3c7](c1af3c7)) ### Bug Fixes * **accordion, accordion-item:** `icon-position`, `icon-type`, `selection-mode` and `scale` can now be set as props or attributes ([#7191](#7191)) ([2b09aba](2b09aba)) * **action-bar:** No longer delegates focus when clicked on non-focusable region ([#7310](#7310)) ([1a9c15c](1a9c15c)) * **action:** Correctly focus the button after rendering updates. ([#7255](#7255)) ([40fe2ce](40fe2ce)) * **block:** Loader now appears for all loading cases ([#7303](#7303)) ([5af3600](5af3600)) * **block:** Removes extra loading indicator ([#7239](#7239)) ([a334a75](a334a75)) * **card:** Ensure teardown logic is called when disconnected ([#7289](#7289)) ([d07e322](d07e322)) * **chip:** Disconnect mutation observer when component is disconnected from the DOM ([#7418](#7418)) ([412e5fb](412e5fb)) * **color-picker:** Draw slider thumbs within bounds ([#7398](#7398)) ([2f37854](2f37854)) * **color-picker:** Fix opacity slider keyboard nudging ([#7400](#7400)) ([2b4f7c3](2b4f7c3)) * **color-picker:** Maintains correct numbering system when entering invalid RGB value ([#7327](#7327)) ([8d2a3a5](8d2a3a5)) * **combobox:** Add space after grouped items ([#7302](#7302)) ([b1580c7](b1580c7)) * **dropdown-item:** Provides accessible label when href is not parsed ([#7316](#7316)) ([966b83d](966b83d)) * **flow:** Call setFocus() on back button click ([#7285](#7285)) ([9102aa4](9102aa4)) * **input-date-picker:** Provides placeholder text context for AT users ([#7320](#7320)) ([31e0ba2](31e0ba2)) * **input-date-picker:** Reset active date picker date after closing ([#7219](#7219)) ([91b2a1b](91b2a1b)) * **input, input-number:** No longer removes trailing decimal separator ([#7159](#7159)) ([01535cf](01535cf)) * **link:** Adds outline-offset to avoid overlapping with text. ([#7342](#7342)) ([c30db4e](c30db4e)) * **list:** Changing filterText property will now update filtered items ([#7133](#7133)) ([a9c0bce](a9c0bce)) * **list:** Fix keyboard navigation after a listItem's disabled or closed property changes ([#7275](#7275)) ([91d28eb](91d28eb)) * **list:** Fix keyboard navigation when filterEnabled is true ([#7385](#7385)) ([41a2e42](41a2e42)) * **menu-item:** Prevent duplicate border in nested vertical menu-items ([#7387](#7387)) ([186a738](186a738)) * **panel:** Remove double border styling when content isn't provided ([#7368](#7368)) ([91a0610](91a0610)) * Remove style modifying all host components with hidden attribute ([#7346](#7346)) ([3103e2f](3103e2f)) * **scrim:** Update loader scale on resize of component. ([#7419](#7419)) ([24e7f70](24e7f70)) * **slider:** Prevent excessive tick rendering ([#7421](#7421)) ([c799409](c799409)) * **switch:** Fix for focus outline style in certain cases ([#7414](#7414)) ([217324f](217324f)) * **tab-title:** Add full focus outline to closable tab button in high contrast mode ([#7272](#7272)) ([d812d17](d812d17)) * **tooltip:** Avoid extra before open/close event emitting ([#7422](#7422)) ([dbb6818](dbb6818)) * **tooltip:** Deprecate the label property due to the description coming from the component's content ([#7247](#7247)) ([7934d75](7934d75)) * **tooltip:** Emits `close` and `beforeClose` events when container is set to `display:none` ([#7258](#7258)) ([60a4683](60a4683)) * **tooltip:** Ensure --calcite-app-z-index-tooltip is applied ([#7345](#7345)) ([a9a7072](a9a7072)) </details> <details><summary>@esri/calcite-components-react: 1.5.0</summary> ## [1.5.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-03) ### Features * Automatically import and define Calcite Components when importing their React wrapper ([#7185](#7185)) ([bf0ff67](bf0ff67)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.5.0-next.38 to ^1.5.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

driskull added 12 commits June 5, 2023 10:58

feat(filter): Add filter method. #6633

4f794d5

Merge branch 'master' into dris0000/filter-method

c8a2518

fix(list): changing filterText property will now update filtered items.

63c510b

#6633

cleanup

4d1f1c0

Merge branch 'dris0000/filter-method' into dris0000/list-filter-fix

17527cc

cleanup

07aeeea

Merge branch 'master' into dris0000/filter-method

9620145

cleanup

9f54ead

Merge branch 'dris0000/filter-method' of github.com:Esri/calcite-comp…

8b4d8a8

…onents into dris0000/filter-method

Merge branch 'dris0000/filter-method' into dris0000/list-filter-fix

8bc9322

cleanup

3a515e7

cleanup

55669b7

github-actions bot assigned driskull Jun 6, 2023

github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 6, 2023

driskull added 5 commits June 5, 2023 18:29

cleanup

48d23bd

Merge branch 'master' into dris0000/filter-method

4592095

fix filteredItems

9414f6b

Merge branch 'dris0000/filter-method' of github.com:Esri/calcite-comp…

1ca7937

…onents into dris0000/filter-method

Merge branch 'dris0000/filter-method' into dris0000/list-filter-fix

fa0a54a

driskull marked this pull request as ready for review June 6, 2023 17:26

driskull requested a review from a team as a code owner June 6, 2023 17:26

driskull added 4 commits June 6, 2023 10:26

Merge branch 'master' into dris0000/list-filter-fix

aa0fe22

Merge branch 'master' into dris0000/filter-method

fd4f7e2

# Conflicts: # packages/calcite-components/src/components/filter/filter.e2e.ts

Merge branch 'dris0000/filter-method' into dris0000/list-filter-fix

77c7609

review fixes

42ff266

driskull requested a review from jcfranco June 14, 2023 23:49

driskull added 2 commits June 16, 2023 11:24

review fixes

96ec73d

Merge branch 'dris0000/filter-method' into dris0000/list-filter-fix

04e92c9

jcfranco approved these changes Jun 16, 2023

View reviewed changes

driskull added this to the 2023 July Priorities milestone Jun 16, 2023

github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 24, 2023

Merge branch 'master' into dris0000/list-filter-fix

67a2aff

driskull merged commit a9c0bce into master Jun 28, 2023

driskull deleted the dris0000/list-filter-fix branch June 28, 2023 18:11

This was referenced Jun 28, 2023

chore: release latest #7237

Closed

chore: release latest #7261

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(list): changing filterText property will now update filtered items #7133

fix(list): changing filterText property will now update filtered items #7133

Uh oh!

driskull commented Jun 6, 2023 •

edited

Loading

Uh oh!

jcfranco left a comment

Uh oh!

jcfranco Jun 16, 2023

Uh oh!

jcfranco Jun 16, 2023

Uh oh!

jcfranco Jun 16, 2023

Uh oh!

github-actions bot commented Jun 24, 2023

Uh oh!

Uh oh!

fix(list): changing filterText property will now update filtered items #7133

fix(list): changing filterText property will now update filtered items #7133

Uh oh!

Conversation

driskull commented Jun 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

jcfranco left a comment

Choose a reason for hiding this comment

Uh oh!

jcfranco Jun 16, 2023

Choose a reason for hiding this comment

Uh oh!

jcfranco Jun 16, 2023

Choose a reason for hiding this comment

Uh oh!

jcfranco Jun 16, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 24, 2023

Uh oh!

Uh oh!

driskull commented Jun 6, 2023 •

edited

Loading