Skip to content

Commit 412e5fb

Browse files
authored
fix(chip): disconnect mutation observer when component is disconnected from the DOM (#7418)
**Related Issue:** #7417 ## Summary ✨🧹✨
1 parent 217324f commit 412e5fb

File tree

1 file changed

+2
-5
lines changed
  • packages/calcite-components/src/components/chip

1 file changed

+2
-5
lines changed

packages/calcite-components/src/components/chip/chip.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ export class Chip
204204
connectInteractive(this);
205205
connectLocalized(this);
206206
connectMessages(this);
207-
this.setupTextContentObserver();
207+
this.mutationObserver?.observe(this.el, { childList: true, subtree: true });
208208
}
209209

210210
componentDidLoad(): void {
@@ -220,6 +220,7 @@ export class Chip
220220
disconnectInteractive(this);
221221
disconnectLocalized(this);
222222
disconnectMessages(this);
223+
this.mutationObserver?.disconnect();
223224
}
224225

225226
async componentWillLoad(): Promise<void> {
@@ -302,10 +303,6 @@ export class Chip
302303
this.hasText = this.el.textContent.trim().length > 0;
303304
}
304305

305-
private setupTextContentObserver() {
306-
this.mutationObserver?.observe(this.el, { childList: true, subtree: true });
307-
}
308-
309306
private handleSlotImageChange = (event: Event): void => {
310307
this.hasImage = slotChangeHasAssignedElement(event);
311308
};

0 commit comments

Comments
 (0)