Skip to content

fix(modal): no longer loses focus trap after clicking inside the component #6504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(modal): no longer loses focus trap after clicking inside the component #6504

wants to merge 2 commits into from

Conversation

jcfranco
Copy link
Member

Related Issue: #6281

Summary

@jcfranco
fix(modal): no longer loses focus trap after clicking inside the comp…
c5f55e9 
…onent

* restores changes reverted by #6483
* bumps focus-trap dep
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 23, 2023
@jcfranco jcfranco marked this pull request as ready for review February 23, 2023 18:12
@jcfranco jcfranco requested a review from a team as a code owner February 23, 2023 18:12
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 23, 2023
@jcfranco jcfranco marked this pull request as draft February 23, 2023 20:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Mar 3, 2023
@jcfranco
Copy link
Member Author

Closing. Will revisit approach in a separate PR.

@jcfranco jcfranco closed this Mar 28, 2023
@jcfranco jcfranco deleted the jcfranco/revisit-reverted-focus-trap-changes branch April 16, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfranco