revert(focus-trap): drop focus-trap options causing inconsistent focus behavior #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/revert-focus-trap-changes-causing-inconsistent-focus-behavior
branch
github-actions
bot
added this to the
2023 February Priorities - 1.1.0 - No breaking changes milestone
jcfranco
added a commit
that referenced
this pull request
Feb 23, 2023
…onent * restores changes reverted by #6483 * bumps focus-trap dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6281 #6454
Summary
Reverts 764609d and df144dc to give us more time to look into other scenarios where focus is being blocked after updating focus-trap configuration.