fix: Enter key should submit forms in Safari #4815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
eriklharper
approved these changes
Jun 28, 2022
|
Yep. I thought we checked and that requestSubmit worked in all browsers but I guess not :\ |
|
@driskull @eriklharper @geospatialem do either of you recall if the original issue only had inputs inside a form? It's no longer available. The polyfill we use for Safari was applied in |
|
I don't recall. I think it just had buttons for submitting. |
|
I don't recall either... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4793
Summary
fix: Enter key should submit forms in Safari (#4793)