Skip to content

form validation not honored in Safari #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcfranco opened this issue Mar 21, 2023 · 2 comments
Closed

form validation not honored in Safari #6626

jcfranco opened this issue Mar 21, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Milestone
2023 March Priori...

Comments

@jcfranco
Copy link
Member

Actual Behavior

Safari submits forms via submit instead of requestSubmit, skipping browser validation.

Expected Behavior

All form submitting uses requestSubmit for consistency.

Reproduction Sample

https://codepen.io/jcfranco/pen/oNPaezj?editors=1001

Reproduction Steps

  1. click on the input
  2. hit enter
  3. notice form submits even though the input is required

Reproduction Version

1.0.8

Relevant Info

This was introduced by #4815.

Regression?

1.0.0-beta.83

Priority impact

p1 - need for current milestone

Impact

No response

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 21, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Mar 21, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Mar 21, 2023
@jcfranco jcfranco self-assigned this Mar 21, 2023
@jcfranco jcfranco mentioned this issue Mar 21, 2023
Merged
jcfranco added a commit that referenced this issue Mar 21, 2023
@jcfranco
fix: restore form control validation in Safari (#6623)
b293077 
**Related Issue:** #6626

## Summary

This restores consistent usage of `requestSubmit` when submitting forms.
`submit` and `requestSubmit` [behave
differently](https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit#usage_notes)
and it was currently not going through form validation in Safari. This
moves the polyfill to the form util to ensure it's available for
components using the form util.
@jcfranco jcfranco added 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. and removed 2 - in development Issues that are actively being worked on. labels Mar 21, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. and removed 3 - installed Issues that have been merged to the "dev" branch and/or are ready for QA/QC. labels Mar 22, 2023
@geospatialem
Copy link
Member

Verified in 1.1.1-next.1

verify-input-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been tested, confirmed as mitigated, and are ready to close. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Projects
None yet
Milestone
2023 March Priorities - No breaking c...
Development

No branches or pull requests
2 participants
@jcfranco @geospatialem