fix(tokens): add missing core color tokens and fix incorrect values #11924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matgalla
added
the
bug
jcfranco
approved these changes
Apr 10, 2025
jcfranco
added
the
pr ready for visual snapshots
|
Found some other discrepancies. Auditing the remaining tokens to account for all differences with the Calcite Colors repo. cc @ashetland |
jcfranco
added
skip visual snapshots
benelan
pushed a commit
that referenced
this pull request
May 14, 2025
…11924) **Related Issue:** #11581 ## Summary Adds `low-saturation` colors that are missing when compared to the original [Calcite Colors](https://github.com/Esri/calcite-colors) repo:  Adds `medium-saturation` colors that are missing when compared to the original [Calcite Colors](https://github.com/Esri/calcite-colors) repo:  Fixes incorrect value for `--calcite-color-vibrant-blue-v-bb-180`:  Fixes incorrect value for `--calcite-color-dark-green-d-gg-430`:  NOTE: In this PR, Tokens Studio changed some minor formatting for all otherwise unchanged token JSON files. This is due to Tokens Studio bypassing the linting process. Addressed in @jcfranco's recent PR here: #11918 This PR is a part of a series of updates that address token-related issues and set them up for use with Tokens Studio. ## Criteria for completion - [x] change `--calcite-color-vibrant-blue-v-bb-180` token value to #0089DE - [x] change `--calcite-color-dark-green-d-gg-430` token value to #11AD1D - [x] add all `low-saturation` color tokens - [x] add all `medium-saturation` color tokens ## Previous steps - [x] #11655 - [x] #11852 ## Next steps - Audit the structural differences between tokens and Figma variables - Restructure tokens to align with Figma variables where necessary - Address #10050 - Address #11565 - Address #11725 - Address #11903 - Audit the value differences between tokens and Figma variables (mainly for percentages and typography) - Finalize token and Figma variable values with Calcite designers and developers - Update token values to align with Figma variables where necessary - Document the new token creation and modification process --------- Co-authored-by: JC Franco <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #11581
Summary
Adds
low-saturationcolors that are missing when compared to the original Calcite Colors repo:Adds
medium-saturationcolors that are missing when compared to the original Calcite Colors repo:Fixes incorrect value for
--calcite-color-vibrant-blue-v-bb-180:Fixes incorrect value for
--calcite-color-dark-green-d-gg-430:NOTE: In this PR, Tokens Studio changed some minor formatting for all otherwise unchanged token JSON files. This is due to Tokens Studio bypassing the linting process. Addressed in @jcfranco's recent PR here: #11918
This PR is a part of a series of updates that address token-related issues and set them up for use with Tokens Studio.
Criteria for completion
--calcite-color-vibrant-blue-v-bb-180token value to #0089DE--calcite-color-dark-green-d-gg-430token value to #11AD1Dlow-saturationcolor tokensmedium-saturationcolor tokensPrevious steps
style-dictionaryand@tokens-studio/sd-transformsto latest #11655Next steps