Skip to content

Commit 6f9ab2c

Browse files
matgallajcfranco
authored andcommitted
fix(tokens): add missing core color tokens and fix incorrect values (#11924)
**Related Issue:** #11581 ## Summary Adds `low-saturation` colors that are missing when compared to the original [Calcite Colors](https://github.com/Esri/calcite-colors) repo: ![image](https://github.com/user-attachments/assets/9fd59ef8-ead2-43be-b80f-9a6cd8e89f14) Adds `medium-saturation` colors that are missing when compared to the original [Calcite Colors](https://github.com/Esri/calcite-colors) repo: ![image](https://github.com/user-attachments/assets/89f58c96-7f25-40b6-a6ae-1efd998c100f) Fixes incorrect value for `--calcite-color-vibrant-blue-v-bb-180`: ![image](https://github.com/user-attachments/assets/f250cf04-b0de-48b8-9e99-581541ec7b68) Fixes incorrect value for `--calcite-color-dark-green-d-gg-430`: ![image](https://github.com/user-attachments/assets/80eef2e1-26d7-4311-b9d8-69353cf83b1a) NOTE: In this PR, Tokens Studio changed some minor formatting for all otherwise unchanged token JSON files. This is due to Tokens Studio bypassing the linting process. Addressed in @jcfranco's recent PR here: #11918 This PR is a part of a series of updates that address token-related issues and set them up for use with Tokens Studio. ## Criteria for completion - [x] change `--calcite-color-vibrant-blue-v-bb-180` token value to #0089DE - [x] change `--calcite-color-dark-green-d-gg-430` token value to #11AD1D - [x] add all `low-saturation` color tokens - [x] add all `medium-saturation` color tokens ## Previous steps - [x] #11655 - [x] #11852 ## Next steps - Audit the structural differences between tokens and Figma variables - Restructure tokens to align with Figma variables where necessary - Address #10050 - Address #11565 - Address #11725 - Address #11903 - Audit the value differences between tokens and Figma variables (mainly for percentages and typography) - Finalize token and Figma variable values with Calcite designers and developers - Update token values to align with Figma variables where necessary - Document the new token creation and modification process --------- Co-authored-by: JC Franco <[email protected]>
1 parent 21955b7 commit 6f9ab2c

24 files changed

+32349
-12291
lines changed

packages/calcite-design-tokens/src/tokens/$metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222
"semantic/color/light",
2323
"semantic/color/dark"
2424
]
25-
}
25+
}

packages/calcite-design-tokens/src/tokens/$themes.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,4 +259,4 @@
259259
},
260260
"group": "shadow"
261261
}
262-
]
262+
]

packages/calcite-design-tokens/src/tokens/core/$metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@
2929
"type": "other"
3030
}
3131
}
32-
}
32+
}

packages/calcite-design-tokens/src/tokens/core/$themes.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
"type": "other"
1616
}
1717
}
18-
}
18+
}

0 commit comments

Comments
 (0)