Skip to content

Encapsulate Simplicity's mallocTransaction inside SimplicityTxData co… #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

roconnor-blockstream
Copy link
Contributor

This PR is in between #1424 and #1425. This PR is optional.

The primary benefit is moving simplicity_elements_mallocTransaction into a structure's constructor, and hiding the SimplicityTransactionDeleter class.

The unique_ptr operations that we use are delegated.

This code is pushing the boundaries of my rusty C++ programming abilities, and it would be good to get a more expert review on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant