Skip to content

Avoid double free in simplicity pointer when copying PrecomputedTransactionData #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Mar 3, 2025

Fixes the following tests

feature_block_v4.py                                 | ✓ Passed  | 3 s
feature_fedpeg.py --legacy-wallet                   | ✓ Passed  | 78 s
feature_fedpeg.py --post_transition --legacy-wallet | ✓ Passed  | 74 s
feature_fedpeg.py --pre_transition --legacy-wallet  | ✓ Passed  | 80 s
feature_nulldummy.py --descriptors                  | ✓ Passed  | 4 s
feature_nulldummy.py --legacy-wallet                | ✓ Passed  | 5 s
feature_sighash_rangeproof.py --legacy-wallet       | ✓ Passed  | 143 s
rpc_fundrawtransaction.py --descriptors             | ✓ Passed  | 971 s
rpc_fundrawtransaction.py --legacy-wallet           | ✓ Passed  | 985 s
rpc_psbt.py --descriptors                           | ✓ Passed  | 216 s
rpc_psbt.py --legacy-wallet                         | ✓ Passed  | 239 s
wallet_bumpfee.py --descriptors                     | ✓ Passed  | 160 s
wallet_bumpfee.py --legacy-wallet                   | ✓ Passed  | 106 s
wallet_keypool.py --descriptors                     | ✓ Passed  | 17 s
wallet_keypool.py --legacy-wallet                   | ✓ Passed  | 10 s
wallet_multisig_descriptor_psbt.py                  | ✓ Passed  | 19 s
wallet_send.py --descriptors                        | ✓ Passed  | 37 s
wallet_send.py --legacy-wallet                      | ✓ Passed  | 36 s
wallet_taproot.py                                   | ✓ Passed  | 150 s
wallet_timelock.py                                  | ✓ Passed  | 2 s
wallet_watchonly.py --usecli --legacy-wallet        | ✓ Passed  | 6 s

There are still 2 failing tests, feature_fee_estimation fails in all arches and the problem is the test itself, needs to be fixed for elements. feature_trim_headers needs some backports from 23.x, but it is working in the release branches

@psgreco psgreco force-pushed the master-win64-fixpsbt branch from 8406f8d to b501f29 Compare March 3, 2025 17:28
@psgreco psgreco requested a review from apoelstra March 3, 2025 17:30
@psgreco psgreco marked this pull request as ready for review March 3, 2025 17:31
@psgreco
Copy link
Contributor Author

psgreco commented Mar 4, 2025

Replaced by #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants