Skip to content

[ACTP] Allow global object in values #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/private-action-runner/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Datadog changelog

## 1.0.3

* Allow a `global` object in values so this chart can be used in a subchart.

## 1.0.2

* Update private action runner version to `v1.2.0`
Expand Down
2 changes: 1 addition & 1 deletion charts/private-action-runner/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: private-action-runner
description: A Helm chart to deploy the private action runner

type: application
version: 1.0.2
version: 1.0.3
appVersion: "v1.2.0"
keywords:
- app builder
Expand Down
2 changes: 1 addition & 1 deletion charts/private-action-runner/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Datadog Private Action Runner

![Version: 1.0.2](https://img.shields.io/badge/Version-1.0.2-informational?style=flat-square) ![AppVersion: v1.2.0](https://img.shields.io/badge/AppVersion-v1.2.0-informational?style=flat-square)
![Version: 1.0.3](https://img.shields.io/badge/Version-1.0.3-informational?style=flat-square) ![AppVersion: v1.2.0](https://img.shields.io/badge/AppVersion-v1.2.0-informational?style=flat-square)

## Overview

Expand Down
4 changes: 4 additions & 0 deletions charts/private-action-runner/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@
}
},
"required": ["config"]
},
"global": {
"type": "object",
"additionalProperties": true
}
},
"required": ["runner"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ metadata:
name: custom-full-name
namespace: datadog-agent
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: override-test
app.kubernetes.io/version: "v1.2.0"
Expand All @@ -92,7 +92,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: override-test
app.kubernetes.io/version: "v1.2.0"
Expand Down
4 changes: 2 additions & 2 deletions test/private-action-runner/__snapshot__/default.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ metadata:
name: default-test-private-action-runner
namespace: datadog-agent
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: default-test
app.kubernetes.io/version: "v1.2.0"
Expand All @@ -92,7 +92,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: default-test
app.kubernetes.io/version: "v1.2.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ metadata:
name: kubernetes-test-private-action-runner
namespace: datadog-agent
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: kubernetes-test
app.kubernetes.io/version: "v1.2.0"
Expand All @@ -136,7 +136,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: kubernetes-test
app.kubernetes.io/version: "v1.2.0"
Expand Down
4 changes: 2 additions & 2 deletions test/private-action-runner/__snapshot__/example.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ metadata:
name: example-test-private-action-runner
namespace: datadog-agent
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: example-test
app.kubernetes.io/version: "v1.2.0"
Expand All @@ -226,7 +226,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: example-test
app.kubernetes.io/version: "v1.2.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ metadata:
name: secrets-test-private-action-runner
namespace: datadog-agent
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: secrets-test
app.kubernetes.io/version: "v1.2.0"
Expand All @@ -90,7 +90,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: private-action-runner-1.0.2
helm.sh/chart: private-action-runner-1.0.3
app.kubernetes.io/name: private-action-runner
app.kubernetes.io/instance: secrets-test
app.kubernetes.io/version: "v1.2.0"
Expand Down