Skip to content

[ACTP] Allow global object in values #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

Conversation

embeaken
Copy link
Contributor

@embeaken embeaken commented Apr 11, 2025

What this PR does / why we need it:

A customer requested this so they can use the PAR as a subchart. This requires that a global object is allowed in the values.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@embeaken embeaken added the private-action-runner/patch-version Patch version bump for private-action-runner chart label Apr 11, 2025
@embeaken embeaken marked this pull request as ready for review April 11, 2025 12:51
@embeaken embeaken requested a review from a team as a code owner April 11, 2025 12:51
@embeaken embeaken requested a review from dd-gplassard April 11, 2025 12:51
@embeaken embeaken merged commit 3f704a7 into main Apr 11, 2025
34 checks passed
@embeaken embeaken deleted the ilya/allow-additional-props-par branch April 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/private-action-runner private-action-runner/patch-version Patch version bump for private-action-runner chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants