Skip to content

chore(tracing): remove deprecated modules [3.0] #12186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Feb 4, 2025
Merged

chore(tracing): remove deprecated modules [3.0] #12186

merged 59 commits into from
Feb 4, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 31, 2025 •
edited
Loading

  • Removes all tracing modules and packages that are not defined in ddtrace._trace, ddtrace.internal, or ddtrace.trace.
  • Removes deprecated tracing attributes from ddtrace. ddtrace.trace should be the sole public interface for tracing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

mabdinur and others added 30 commits January 27, 2025 17:29
@mabdinur
chore(tracing): avoid using deprecated code internally
a75aa9a
@mabdinur
chore(tracing): remove deprecated modules 3.0
c092d57
@mabdinur
fix docs
d5ba6fa
@mabdinur
fix typing
a8b1d89
@mabdinur
Merge branch 'munir/avoid-using-deprecated-apis-internally' into muni…
02edc9d 
…r/remove-deprecated-tracing-modules
@mabdinur
don't remove deprecations
d3f0d1a
@mabdinur
update tests
deeeb84
@mabdinur
Merge branch 'munir/avoid-using-deprecated-apis-internally' into muni…
5d1a37e 
…r/remove-deprecated-tracing-modules
@mabdinur
removing tracing
d0d966e
@mabdinur
update suitespec
4d6a286
@mabdinur
remove deprecated tracing module from tests
3ffdf51
@mabdinur
remove test for deprecated module
49348e9
@mabdinur
undo py version check removal and fix langchain/tornado
8351e5c
@mabdinur
don't remove py version check
851229a
@mabdinur
Merge branch 'munir/avoid-using-deprecated-apis-internally' into muni…
bbbf1db 
…r/remove-deprecated-tracing-modules
@mabdinur
fix docs
5320ea8
@mabdinur
fix gevent and testagent
499e080
@mabdinur
Merge branch 'munir/avoid-using-deprecated-apis-internally' into muni…
bb45fb6 
…r/remove-deprecated-tracing-modules
@mabdinur
fix testagent test
2734d43
@mabdinur
fix selenium
091b225
@mabdinur
Merge branch 'munir/avoid-using-deprecated-apis-internally' into muni…
47bb172 
…r/remove-deprecated-tracing-modules
@mabdinur
fix trace handlers
b79a3b4
@mabdinur
fix failing civis test
7863735
@mabdinur
fix rn
1a26940
@mabdinur
fmt
ae9325a
@mabdinur
fix benchmarks
6d7762d
@mabdinur
fmt
8a31953
@mabdinur
match imports
b74e5b5
@mabdinur
revert __init__ changes
589c330
@mabdinur
Merge branch '3.x-staging' into munir/avoid-using-deprecated-apis-int…
f155c2a 
…ernally
Base automatically changed from munir/upgrade-min-aws-lambda to 3.x-staging January 31, 2025 17:17
@mabdinur mabdinur enabled auto-merge (squash) February 3, 2025 13:30
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch 2 times, most recently from 6145686 to 8be593b Compare February 3, 2025 22:06
erikayasuda
erikayasuda approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@erikayasuda erikayasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mabdinur mabdinur requested a review from a team as a code owner February 3, 2025 23:15
mabdinur
mabdinur commented Feb 4, 2025
View reviewed changes
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from a886c24 to 9c6a0ca Compare February 4, 2025 05:18
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from 9c6a0ca to dfc581f Compare February 4, 2025 05:33
@mabdinur mabdinur merged commit 63d13ab into 3.x-staging Feb 4, 2025
670 checks passed
@mabdinur mabdinur deleted the munir/remove-deprecated-tracing-modules branch February 4, 2025 06:22
@mabdinur mabdinur mentioned this pull request Feb 4, 2025
Merged
2 tasks
mabdinur added a commit that referenced this pull request Feb 4, 2025
@mabdinur
ci(benchmarks): fix failing microbenchmarks (#12217)
514f5f2 
#12186 removed deprecated
parameters from `tracer.configure(...)` and `rate_limiter.allowed(...)`
but did not update the microbenchmarks. This PR address this issue.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
gnufede pushed a commit that referenced this pull request Feb 19, 2025
@mabdinur @gnufede
chore(tracing): remove deprecated modules [3.0] (#12186)
0933b28 
- Removes all tracing modules and packages that are not defined in
ddtrace._trace, ddtrace.internal, or ddtrace.trace.
- Removes deprecated tracing attributes from ddtrace. ddtrace.trace
should be the sole public interface for tracing.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
@cswartzvi cswartzvi mentioned this pull request Mar 2, 2025
Merged
7 tasks
cswartzvi added a commit to cswartzvi/hamilton that referenced this pull request Mar 2, 2025
@cswartzvi
Pin ddtrace<3.0 until issue with modules can be evaluated
1ff0908 
For more info see: DataDog/dd-trace-py#12186
@cswartzvi cswartzvi mentioned this pull request Mar 2, 2025
Merged
7 tasks
cswartzvi added a commit to cswartzvi/hamilton that referenced this pull request Mar 2, 2025
@cswartzvi
Pin ddtrace<3.0 until issue with modules can be evaluated
d04151d 
For more info see: DataDog/dd-trace-py#12186
skrawcz pushed a commit to apache/hamilton that referenced this pull request Mar 3, 2025
@cswartzvi
Pin ddtrace until deprecated module can be evaluated (#1288)
fbded2f 
This is because "Span" was moved / deprecated. Need to evaluate this 
major version bump so we're pinning for the meantime.

* Pin `ddtrace<3.0` until issue with modules can be evaluated

For more info see: DataDog/dd-trace-py#12186

* Pin `ddtrace<3.0` for docs

* Add comments about pin/deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufede gnufede gnufede approved these changes

@ZStriker19 ZStriker19 ZStriker19 approved these changes

@Yun-Kim Yun-Kim Yun-Kim approved these changes

@erikayasuda erikayasuda erikayasuda approved these changes

@rachelyangdog rachelyangdog Awaiting requested review from rachelyangdog rachelyangdog is a code owner automatically assigned from DataDog/apm-sdk-api-python

@sanchda sanchda Awaiting requested review from sanchda sanchda is a code owner automatically assigned from DataDog/python-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mabdinur @gnufede @ZStriker19 @Yun-Kim @erikayasuda