Skip to content

Commit fbded2f

Browse files
authored
Pin ddtrace until deprecated module can be evaluated (#1288)
This is because "Span" was moved / deprecated. Need to evaluate this major version bump so we're pinning for the meantime. * Pin `ddtrace<3.0` until issue with modules can be evaluated For more info see: DataDog/dd-trace-py#12186 * Pin `ddtrace<3.0` for docs * Add comments about pin/deprecation
1 parent 370c289 commit fbded2f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

hamilton/plugins/h_ddog.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
logger = logging.getLogger(__name__)
1010
try:
11+
# TODO: this works for ddtrace < 3.0; Span was deprecated in 3.0
12+
# See https://github.com/DataDog/dd-trace-py/pull/12186
1113
from ddtrace import Span, context, tracer
1214
except ImportError as e:
1315
logger.error("ImportError: %s", e)

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ dask-core = ["dask-core"]
4141
dask-dataframe = ["dask[dataframe]"]
4242
dask-diagnostics = ["dask[diagnostics]"]
4343
dask-distributed = ["dask[distributed]"]
44-
datadog = ["ddtrace"]
44+
datadog = ["ddtrace<3.0"] # Temporary pin until h_ddog.py import is fixed for >3.0 version
4545
dev = [
4646
"pre-commit",
4747
"ruff==0.5.7", # this should match `.pre-commit-config.yaml`
@@ -53,7 +53,7 @@ docs = [
5353
"commonmark==0.9.1", # read the docs pins
5454
"dask-expr; python_version == '3.9'",
5555
"dask[distributed]",
56-
"ddtrace",
56+
"ddtrace<3.0",
5757
"diskcache",
5858
# required for all the plugins
5959
"dlt",

0 commit comments

Comments
 (0)