[STAL-2465] Switch to ddsa runtime #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonforal
requested review from
iniyarajamani and
juli1
and removed request for
iniyarajamani
juli1
approved these changes
Jul 15, 2024
…uring initial ddsa development.
|
Rebasing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The ddsa runtime solves numerous performance issues, as well as enabling functionality that will allow more powerful and accurate rules to be written.
This was a complete re-write of our existing JavaScript runtime, and so for caution, we implemented it as a feature flag so that we could test it internally to ensure parity across a larger sample size of files and usage (#428).
Running for two weeks confirmed parity (and where not 100%, it is due to false positives/negatives that this PR fixes)
What is your solution?
--ddsa-runtimeas a CLI flag for both the analyzer and the server. Our binaries throw an error upon receiving an unexpected CLI flag, and so to give time for users to change existing usage, we "deprecate" the flag now via a printed warning. We will remove this flag in a future release. (we already clarified the flag was for "internal" use, so this method of deprecating is appropriate)Alternatives considered
What the reviewer should know