Remove dead_code override that was used to improve dev ergonomics during initial ddsa development.

Author: jasonforal

crates/static-analysis-kernel/src/analysis/ddsa_lib.rs

@@ -2,15 +2,13 @@
 // This product includes software developed at Datadog (https://www.datadoghq.com/).
 // Copyright 2024 Datadog, Inc.
 
-#[allow(dead_code)]
 pub mod bridge;
 pub mod common;
 pub mod context;
 pub use context::*;
 pub mod extension;
 pub(crate) mod js;
 pub(crate) mod ops;
-#[allow(dead_code)]
 pub(crate) mod runtime;
 pub(crate) use runtime::JsRuntime;
 #[allow(dead_code)]

crates/static-analysis-kernel/src/analysis/ddsa_lib/bridge/ts_node.rs

@@ -202,9 +202,6 @@ mod tests {
         fn parse(&mut self, text: &'static str) -> Tree {
             Tree(Arc::new(self.0.parse(text, None).unwrap()), text)
         }
-        fn language(&self) -> tree_sitter::Language {
-            self.0.language().unwrap()
-        }
     }
 
     /// Compares whether a [`TreeSitterNodeObj`] has equivalent data to a [`tree_sitter::Node`].

crates/static-analysis-kernel/src/analysis/ddsa_lib/bridge/violation.rs

@@ -70,11 +70,9 @@ mod tests {
     /// Tests the statefulness of the bridge, and that it can be cleared between executions.
     #[test]
     fn violations_bridge_drains() {
-        let mut runtime = cfg_test_runtime();
+        let (mut runtime, mut v_bridge) = setup_bridge("VIOLATIONS");
         let scope = &mut runtime.handle_scope();
-        let mut v_bridge = ViolationBridge::new(scope);
         let v8_v_bridge = v_bridge.as_local(scope);
-        attach_as_global(scope, v8_v_bridge, "VIOLATIONS");
         assert_eq!(v8_v_bridge.length(), 0);
 
         let violations = v_bridge.drain_collect(scope).unwrap();
@@ -98,11 +96,9 @@ VIOLATIONS.push(v);
     /// Tests that the bridge is cleared when `drain_collect` is called, even if there were deserialization errors.
     #[test]
     fn violations_bridge_invalid_obj() {
-        let mut runtime = cfg_test_runtime();
+        let (mut runtime, mut v_bridge) = setup_bridge("VIOLATIONS");
         let scope = &mut runtime.handle_scope();
-        let mut v_bridge = ViolationBridge::new(scope);
         let v8_v_bridge = v_bridge.as_local(scope);
-        attach_as_global(scope, v8_v_bridge, "VIOLATIONS");
         assert_eq!(v8_v_bridge.length(), 0);
 
         let code = r#"

crates/static-analysis-kernel/src/analysis/ddsa_lib/runtime.rs

@@ -53,6 +53,7 @@ pub struct JsRuntime {
     ts_query_cursor: Rc<RefCell<tree_sitter::QueryCursor>>,
     // v8-specific
     /// A [`v8::Object`] that has been set as the prototype of the `JsRuntime`'s default context's global object.
+    #[allow(dead_code)]
     v8_ddsa_global: v8::Global<v8::Object>,
 }