Skip to content

Migrate to aws-xray-sdk-go/v2 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

Motivation

Original PR: #190. Opening here so we can run the integration tests.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@purple4reina purple4reina requested a review from a team as a code owner March 6, 2025 23:46
@purple4reina purple4reina mentioned this pull request Mar 6, 2025
10 tasks
@purple4reina
Copy link
Contributor Author

I tested this and can confirm that merging xray traces still works as expected. Created a lambda function which makes an http call to another lambda function, both with xray tracing enabled. I was able to see the xray spans properly merged with the dd spans.

Copy link
Contributor

@nhulston nhulston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the aws-xray-sdk-go version in the integration tests? e.g. https://github.com/DataDog/datadog-lambda-go/blob/11287d33321ef7e39820e54d215ea98c45978882/tests/integration_tests/error/go.mod

otherwise LGTM

@purple4reina
Copy link
Contributor Author

Do we need to update the aws-xray-sdk-go version in the integration tests? e.g. 11287d3/tests/integration_tests/error/go.mod

otherwise LGTM

Interesting. The tests still pass without that update. I think go mod replace must know the right thing to do? Output from the build shows the correct version of xray sdk was used too https://github.com/DataDog/datadog-lambda-go/actions/runs/13710484821/job/38345752829?pr=194#step:8:14. I say let's keep it how it is, if it aint broke don't fix it.

@purple4reina purple4reina merged commit 4a013a3 into main Mar 7, 2025
11 of 12 checks passed
@purple4reina purple4reina deleted the rey.abolofia/migrate-to-xrayv2 branch March 7, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants