Skip to content

Migrate to aws-xray-sdk-go/v2 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

krzysiek1507
Copy link
Contributor

@krzysiek1507 krzysiek1507 commented Feb 28, 2025

What does this PR do?

Migrate to aws-xray-sdk-go/v2 so we don't pull aws-sdk-go v1 anymore.

Motivation

aws-xray-sdk-go v1 uses aws-sdk-go v1 which is heave and also not used in the repo.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Checklist

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@krzysiek1507 krzysiek1507 requested a review from a team as a code owner February 28, 2025 15:53
@krzysiek1507
Copy link
Contributor Author

Hey @purple4reina! Would you be able to take a look at this PR? Thanks!

@krzysiek1507
Copy link
Contributor Author

Any idea why ENV variables would be empty for the integration test?

No AWS credentials were found in the environment.

@purple4reina purple4reina mentioned this pull request Mar 6, 2025
10 tasks
@purple4reina
Copy link
Contributor

Hey @krzysiek1507, thanks a ton for the contribution. I've reopened your branch under a new PR at #194 so that we can run the integration tests.

@krzysiek1507
Copy link
Contributor Author

@purple4reina thank you very much! Once the other PR is merged, I would really appreciate a new release

@krzysiek1507 krzysiek1507 deleted the migrate-to-xrayv2 branch March 7, 2025 10:15
@purple4reina
Copy link
Contributor

https://github.com/DataDog/datadog-lambda-go/releases/tag/v1.22.0 has been released with these changes 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants