Skip to content

Migrate CI to dda #33587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2025
Merged

Migrate CI to dda #33587

merged 9 commits into from
Mar 5, 2025

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 30, 2025

What does this PR do?

  • Remove use of requirements files in favor of centralized dependency management in dda
  • Adds a custom composite action for easily installing the proper version of dda in GitHub Actions workflows

Motivation

Continuation of DataDog/datadog-agent-buildimages#741

Describe how you validated your changes

  • Ran rg -. "requirements.+txt"
  • Ran rg -. "inv "
  • Removed associated logic in favor of dda usage

@ofek ofek requested a review from a team as a code owner January 30, 2025 16:09
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 30, 2025
@ofek ofek force-pushed the ofek/requirements branch 2 times, most recently from 7d9d6bd to e6cbe38 Compare January 30, 2025 16:54
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 30, 2025

Uncompressed package size comparison

Comparison with ancestor 0c8c8518e6b24005652a7e3abeab93731ebef863

Size reduction summary
package diff status size ancestor threshold
datadog-agent-aarch64-rpm -0.00MB 816.18MB 816.18MB 0.50MB
datadog-agent-arm64-deb -0.00MB 806.41MB 806.41MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 815.46MB 815.46MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 825.26MB 825.26MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 825.26MB 825.26MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.44MB 39.44MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.51MB 39.51MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.97MB 37.97MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.81MB 440.81MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.14MB 62.14MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.21MB 62.21MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.21MB 62.21MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.37MB 59.37MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.44MB 59.44MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Jan 30, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 368da4b0-cd9f-4abf-a78d-3059410befbf

Baseline: 0c8c851
Comparison: 6bdd9f4
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.40 [+0.37, +0.43] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.07 [+0.04, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.66, +0.73] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.74, +0.79] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.77, +0.81] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.84, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.29, +0.30] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.71, +0.68] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.17 [-0.64, +0.30] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.28 [-1.06, +0.50] 1 Logs
file_tree memory utilization -0.48 [-0.53, -0.42] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.69 [-0.75, -0.63] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.03 [-2.00, -0.06] 1 Logs
quality_gate_logs % cpu utilization -2.56 [-5.41, +0.29] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@ofek ofek added qa/no-code-change No code change in Agent code requiring validation do-not-merge/WIP labels Jan 30, 2025
@ofek ofek force-pushed the ofek/requirements branch from e6cbe38 to ed554f2 Compare January 31, 2025 06:44
@ofek ofek requested review from a team as code owners January 31, 2025 06:44
@ofek ofek requested a review from a team January 31, 2025 06:44
@ofek ofek requested a review from a team as a code owner January 31, 2025 06:44
@ofek ofek force-pushed the ofek/requirements branch from bc42134 to 84cbe45 Compare February 28, 2025 14:43
@ofek ofek changed the title Migrate CI to deva Migrate CI to dda Feb 28, 2025
@ofek ofek force-pushed the ofek/requirements branch from 84cbe45 to 8d03aa0 Compare February 28, 2025 15:26
@ofek ofek marked this pull request as draft February 28, 2025 15:31
@ofek ofek force-pushed the ofek/requirements branch from b5101d8 to e9e1184 Compare February 28, 2025 20:25
@ofek ofek marked this pull request as ready for review March 3, 2025 16:10
@ofek
Copy link
Contributor Author

ofek commented Mar 4, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 4, 2025

View all feedbacks in Devflow UI.
2025-03-04 14:51:18 UTC ℹ️ Start processing command /merge


2025-03-04 14:51:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-04 18:52:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@ofek ofek force-pushed the ofek/requirements branch from e9e1184 to c3c8517 Compare March 4, 2025 18:37
@ofek ofek merged commit a572681 into main Mar 5, 2025
466 checks passed
@ofek ofek deleted the ofek/requirements branch March 5, 2025 21:59
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 5, 2025
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
github-actions bot pushed a commit to Stars1233/datadog-agent that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-developer-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.