Remove dynamic installation of KMT dependencies #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
commented
Mar 5, 2025
|
|
||
| if no_dynamic_deps: | ||
| import sys | ||
|
|
||
| app.subprocess.replace_current_process([sys.executable, "-m", "invoke", *args]) | ||
| return |
There was a problem hiding this comment.
My editor spotted that this is unreachable code based on the type annotations but I'm not sure why CI doesn't catch that, perhaps that has to be explicitly configured. I will investigate at a later time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 72.65% 72.79% +0.14%
==========================================
Files 67 68 +1
Lines 1788 1790 +2
Branches 114 113 -1
==========================================
+ Hits 1299 1303 +4
+ Misses 447 446 -1
+ Partials 42 41 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies must be manually installed only after system requirements are met, see DataDog/datadog-agent#33587 (comment)