discovery: Explicitly close opened files

[vitkyrka]

What does this PR do?

A few code paths missed explicitly closing opened files; add this.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[guyarb]

Is it possible to use linter / ut to verify this is being captured in the next time?

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43046074 --os-family=ubuntu

Note: This applies to commit 6295a6d

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 0120d76f-fae0-4cc9-8c60-30d9a5f708dd Metrics dashboard Target profiles

Baseline: 2f3053a
Comparison: 6295a6d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_tree	memory utilization	+1.60	[+1.51, +1.70]	Logs
➖	idle	memory utilization	+0.59	[+0.54, +0.65]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.56	[-0.40, +1.52]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.08	[-0.89, +0.73]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.07	[-13.78, +11.64]	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-1.22	[-3.65, +1.21]	Logs
➖	basic_py_check	% cpu utilization	-1.72	[-4.37, +0.92]	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[vitkyrka]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!