Skip to content

Commit 5d954e9

Browse files
authored
discovery: Explicitly close opened files (#28859)
1 parent e99ce1d commit 5d954e9

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

pkg/collector/corechecks/servicediscovery/usm/nodejs.go

+1
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ func (n nodeDetector) maybeExtractServiceName(filename string) (string, bool) {
9696
if err != nil {
9797
return "", false
9898
}
99+
defer file.Close()
99100
ok, err := canSafelyParse(file)
100101
if err != nil {
101102
//file not accessible or don't exist. Continuing searching up

pkg/collector/corechecks/servicediscovery/usm/tomcat.go

+1
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ func (te tomcatExtractor) parseServerXML(domainHome string) *tomcatServerXML {
132132
log.Debugf("Unable to locate tomcat server.xml (%q). Err: %v", xmlFilePath, err)
133133
return nil
134134
}
135+
defer file.Close()
135136
var serverXML tomcatServerXML
136137
err = xml.NewDecoder(file).Decode(&serverXML)
137138
if err != nil {

0 commit comments

Comments
 (0)