Skip to content

Add opt out of converter instructions #28583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Aug 20, 2024

What does this PR do?

This PR adds instructions on how to opt out of the converter (supported pending the following PR #28536), as well as instructions + examples on how to opt in manually to some components. Note that the link to infraattributes processor and datadog extension README are dead links pending adding READMEs to these components.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@mackjmr mackjmr requested a review from a team as a code owner August 20, 2024 12:54
@mackjmr mackjmr requested a review from songy23 August 20, 2024 12:54
@github-actions github-actions bot added the team/opentelemetry OpenTelemetry team label Aug 20, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 20, 2024

[Fast Unit Tests Report]

On pipeline 43253226 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Aug 20, 2024

Regression Detector

Regression Detector Results

Run ID: e176be38-9408-41e8-8d5b-e81657e6f319 Metrics dashboard Target profiles

Baseline: 47bab67
Comparison: 8d43512

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +3.48 [-9.42, +16.39] Logs
pycheck_lots_of_tags % cpu utilization +1.06 [-1.42, +3.53] Logs
otel_to_otel_logs ingress throughput +0.35 [-0.46, +1.16] Logs
idle memory utilization +0.34 [+0.31, +0.38] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.04, +0.02] Logs
file_tree memory utilization -0.07 [-0.14, -0.01] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.97 [-1.92, -0.03] Logs
basic_py_check % cpu utilization -2.69 [-5.28, -0.10] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@mackjmr mackjmr requested a review from akt-datadog August 20, 2024 14:02
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume no QA is needed?

@mackjmr mackjmr added the qa/no-code-change No code change in Agent code requiring validation label Aug 20, 2024
…datadog-agent into mackjmr/update-converter-readme
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackjmr
Copy link
Member Author

mackjmr commented Aug 30, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 30, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 9ce02da into main Aug 30, 2024
205 of 217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mackjmr/update-converter-readme branch August 30, 2024 14:34
@github-actions github-actions bot added this to the 7.58.0 milestone Aug 30, 2024
truthbk pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants