-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add opt out of converter instructions #28583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[Fast Unit Tests Report] On pipeline 43253226 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsRun ID: e176be38-9408-41e8-8d5b-e81657e6f319 Metrics dashboard Target profiles Baseline: 47bab67 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +3.48 | [-9.42, +16.39] | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +1.06 | [-1.42, +3.53] | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.35 | [-0.46, +1.16] | Logs |
➖ | idle | memory utilization | +0.34 | [+0.31, +0.38] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.04, +0.02] | Logs |
➖ | file_tree | memory utilization | -0.07 | [-0.14, -0.01] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.97 | [-1.92, -0.03] | Logs |
➖ | basic_py_check | % cpu utilization | -2.69 | [-5.28, -0.10] | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume no QA is needed?
Co-authored-by: Yang Song <[email protected]>
…datadog-agent into mackjmr/update-converter-readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Co-authored-by: Yang Song <[email protected]>
What does this PR do?
This PR adds instructions on how to opt out of the converter (supported pending the following PR #28536), as well as instructions + examples on how to opt in manually to some components. Note that the link to infraattributes processor and datadog extension README are dead links pending adding READMEs to these components.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes