Make converter optional

[mackjmr]

What does this PR do?

This PR makes the converter optional in OTel agent. It is enabled by default, but users now have an option to disable it in agent config.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Run the agent with the otelcollector.converter.enabled set to false (or via env DD_OTELCOLLECTOR_CONVERTER_ENABLED=false and ensure the collector config does not get enhanced)

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42253320 --os-family=ubuntu

Note: This applies to commit 356a2ae

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 4de6e420-03a2-4fb7-a4c1-90e9e250a88d Metrics dashboard Target profiles

Baseline: 3923572
Comparison: 356a2ae

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	pycheck_1000_100byte_tags	% cpu utilization	+1.59	[-3.31, +6.48]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.22	[+0.32, +2.13]	Logs
➖	idle	memory utilization	+0.82	[+0.78, +0.87]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.17	[-0.98, +0.64]	Logs
➖	file_tree	memory utilization	-0.71	[-0.82, -0.60]	Logs
➖	basic_py_check	% cpu utilization	-1.90	[-4.56, +0.77]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-5.99	[-18.52, +6.54]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[mackjmr]

/merge -c

[dd-devflow]

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

[hush-hush]

Looks good for the files owned by ASC

[mackjmr]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!