[fix] move i18n pre-commit check inside Windows conditional block #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses PR review feedback to ensure the i18n unused keys check works properly on Windows by using npx.cmd instead of npx, following the same pattern as lint-staged.
christian-byrne
added a commit
that referenced
this pull request
Jul 7, 2025
…uLabels ignore pattern - Replace bash-specific [[ syntax with POSIX [ in pre-commit hook - Add menuLabels.* to ignore patterns for dynamically constructed translation keys - Fixes CI failures introduced in PR #4353 where [[ syntax fails in sh environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Windows compatibility issue with the i18n unused keys check in pre-commit hook by using npx.cmd on Windows. Addresses review feedback from #4328.
┆Issue is synchronized with this Notion page by Unito