Add unused i18n keys detection to pre-commit hook #4328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a pre-commit script so let's merge this for now. If it is giving false positives or causing trouble we can disable later. It was tested as described in the PR description. |
comfy-jinyi
pushed a commit
that referenced
this pull request
Jul 4, 2025
webfiltered
reviewed
Jul 4, 2025
| @@ -3,3 +3,6 @@ if [[ "$OS" == "Windows_NT" ]]; then | |||
| else | |||
| npx lint-staged | |||
| fi | |||
|
|
|||
| # Check for unused i18n keys in staged files | |||
| npx tsx scripts/check-unused-i18n-keys.ts | |||
There was a problem hiding this comment.
This breaks on windows; please mimic above (ridiculous) if/else workaround.
There was a problem hiding this comment.
got it, making PR now!
This was referenced Jul 4, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
┆Issue is synchronized with this Notion page by Unito