-
Notifications
You must be signed in to change notification settings - Fork 241
Adds few utilities for stretched coordinates + Docs/Grids section on how to use these utils #4623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…gans.jl into ncc/ExponentialInterfaces
What's the rationale? I think there are disadvantages to overlapping scope between the packages so it'd nice to clarify what-belongs-where. I think ClimaOcean concerns should be focused on OceanSeaIceModel whereas anything to do with grid generation is more fundamental and seems to be an Oceananigans concern? |
src/Grids/stretched_coordinates.jl
Outdated
@@ -0,0 +1,111 @@ | |||
struct ExponentialCoordinate <: Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could relax the Function
constraint in this PR as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a unique type otherwise it's not picked up by validate_dimension_specification
method.
I defined a new abstract type.
I agree with the comments. I'll make the changes and ping you! |
Yes, feels natural. |
@glwagner, I brought everything here and renamed it to |
Originally developed at CliMA/ClimaOcean.jl#565
This PR brings utilities for constructing variably-spaced coordinates from ClimaOcean to Oceananigans. Namely
ExponentialCoordinate
andConstantToStretchedCoordinate
. The main features implemented in this PR are insrc/Grids/coordinate_utils.jl
+ the Docs/Grids corresponding section that demonstrates their functionality.The PR also makes minor several fixes in other docstrings.
Docs preview at https://clima.github.io/OceananigansDocumentation/previews/PR4623/grids/#Coordinate-helper-utilities