-
Notifications
You must be signed in to change notification settings - Fork 18
(0.7.0) Revamp VerticalGrids + add Docs for VerticalGrids #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 23.42% 21.10% -2.33%
==========================================
Files 48 48
Lines 2869 2886 +17
==========================================
- Hits 672 609 -63
- Misses 2197 2277 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
exponential_z_faces API changed
716c0c6
to
87cf7d4
Compare
merge? |
experiments/coupled_simulation/ocean_sea_ice_coupled_simulation.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Grid utilities" is a better name than "Vertical grids" now. but this belongs in Oceananigans too
Merging now. CliMA/Oceananigans.jl#4623 aims to move ExponentialCoordinate to Oceananigans. When that's merged we can drop it from ClimaOcean. |
#565 left all examples commented out accidentally
#565 left all examples commented out accidentally
This is ready for review.
The PR changes the user interface for creating vertical grids.
Also adds a section in the Docs describing the vertical grids. Preview should be here but it might take few hours until you get the final version
https://clima.github.io/ClimaOceanDocumentation/previews/PR565/vertical_grids/
Next should come a PR with a vertical grid implementation that allows us to specify surface spacing, Nz and depth. Will probably involve iterative process, e.g. in the spirit of https://doi.org/10.1016/j.ocemod.2017.03.012