Dresses audit

[BalthazarArgall]

Summary

Content "Dresses audit"

Purpose of change

Our dresses are a mess, almost all of them are various halloween costumes, in fact we have more types of dresses through costumes than from basic clothes. Stuff like witch dresses exist in short, medium and long variants, we have costumes with sleeves and other sleeveless while our "normal" dresses are pathetically limited.

Describe the solution

I added 5 new dresses on top of the already existing one, they cover the vast majority of the dresses we already have in game and probably also the ones we may add in the future so they can be added directly as variants. A lot of existing Halloween dresses have been converted to variants of these. The added dress also cleanly copy-from each other to keep the definitions light and readable.

I'll list them and what existing costumes have been variantized into them:

1. Dress (None)
2. Long dress

• Gown (technically variantized in another PR precursor to this one)

3. Short dress

• Short sinister dress

4. Dress with sleeves

• All the regular witch dress variants

5. Long dress with sleeves

• Sinister gown
• All the long witch dress variants

6. Short dress with sleeves

• All the short witch dress variants

Distributions have been adjusted accordingly and existing items added to the migration file.

Describe alternatives you've considered

A few dresses items and costumes have been left untouched:

• Sundress: Could have been made a short dress variant but it's ultra light and thin nature with no warmth value is enough to warrant being it's own item.
• Santa dresses: Could have been turned into variants but they have faux-fur material, which justifies them being their own items, they could also be somehow dismantled for this material where regular dresses can't.
• Sinister dress: Could be a long dress with sleeves variant but it has a "COLLAR" flag and it mentions it in its description, I don't know how relevant this is to actual gameplay but this technically warrants being its own item.
• Ninja dress: I plan on reworking those into actual chinese traditional clothing, which they're already somewhat emulating by having no sleeves but covering the shoulders, hence technically warranting being their own items.

Testing

Launched the game, no error, spawned a dress, no issue, it's a lot of changes so this is probably not enough.

Additional context

Do tell me if you disagree with me on whether some of the dresses mentioned should actually get variantized. There's nothing that would make me more happy than turning more of these into variants.

The long commit list is due to me working from the Gown audit PR branch. Probably don't merge before #80917.

[Maleclypse]

Gowns and dresses aren't the same and shouldn't have the same encumbrance or material thicknesses

[Termineitor244]

I added basically all the Halloween dresses mentioned, personally I have no problem with most of them being turned into variants since you are already adding the base items to differentiate between them, and you already taking into account special cases like the Santa dresses which use a different material that could be harvested from them.

[BalthazarArgall]

@Maleclypse I was reverting gown changes when Guardian merged #80917, what do I make of that? Do I go through with the revert or not?

[BalthazarArgall]

I'm done, requested changes made, this now includes a revert of #80917.

[BalthazarArgall]

@Maleclypse I apologize for the ping, I want to implement new dresses which may rely on items changed here so I wanted some closure on this so I know from which branch to start.

If you can't review atm it's fine, I'll work on other stuff, I just wanted to know