Skip to content

Gown audit #80917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

Gown audit #80917

merged 6 commits into from
May 15, 2025

Conversation

BalthazarArgall
Copy link
Contributor

@BalthazarArgall BalthazarArgall commented May 13, 2025

Summary

Content "Gown audit"

Purpose of change

We have a gown item and a dress item, this would probably mean that those are supposed to be different from each other, well, turns out that what the difference boils down to IRL is that gowns are supposed to be "more formal" and tend to be long. What a coincidence, our dress item is supposed to be long too and "formality" boils down to superficial appearance differences, plus our dress item is supposed to be 180 dollarinos! Well ain't that fancy.

Describe the solution

  • Add "long" in our dress item name since it is and we are probably going to have short dresses in the future.
  • Create a few dress variants, white, black and gown, weights are 4/4/1 so ~10% of dresses will be gowns.
  • Adjust item distributions.
  • Migrate gowns to the dress variant.
  • Remove the gown.

Describe alternatives you've considered

Not pulling variant weight distribution out of my rear, if someone has a good source for dresses to gowns proportion in NE hit me up.

Testing

Done, not extensively.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod Items: Armor / Clothing Armor and clothing Mods: Xedra Evolved Anything to do with Xedra Evolved labels May 13, 2025
@github-actions github-actions bot requested review from KorGgenT and Maleclypse May 13, 2025 11:07
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 13, 2025
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • black dresss
  • white dresss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 13, 2025
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 13, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 14, 2025
@GuardianDll GuardianDll merged commit 1ca3385 into CleverRaven:master May 15, 2025
27 of 40 checks passed
@BalthazarArgall BalthazarArgall deleted the GownAudit branch May 18, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants