Create expressions by SessionContext API #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Jul 19, 2024
Comment on lines
+156
to
+157
| /// Add the table prefix for the column expression if it can be resolved by the schema. | ||
| fn qualified_expr( |
There was a problem hiding this comment.
I have filed an issue apache/datafusion#11551 for it. If the behavior is improved, we can remove this function.
grieve54706
approved these changes
Jul 22, 2024
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* upgrade to 40.0.0 and fix the api * fix the test cases * update lock * adjust Dataset location * use seesion_state to create the required expr * fix test * fix format and clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #681 (comment), DataFusion moves many functions out of the core. If we used the context provider and created the expression by ourselves, we should register many functions for it. This PR uses
SessionCotnext#SessionStateto create what we need.